refactor: ♻️ Code refactorization for improve code maintainability

Author: DevKevvz

src/index.ts

@@ -1,57 +1,26 @@
 /**
- * The function `documentValidator` in TypeScript validates a Dominican Republic
+ * The function `documentValidator` validates a Dominican Republic
  * identification document number.
- * @param {string} document - The code you provided is a function that validates a Dominican Republic
- * national identification document number (Cédula de Identidad y Electoral). The function takes a
+  @param {string} document - The document number to validate (Cédula de Identidad y Electoral).
  * string representing the document number as input and performs a series of calculations to validate
  * it.
  * @returns The function `documentValidator` is returning a boolean value - `true` if the
  * provided Dominican document number is valid, and `false` if it is not valid.
  */
 export function documentValidator(document: string): boolean {
-  const documentId: string = removeHyphens(document);
+  try {
+    const documentId: string = removeHyphens(document);
 
-  if (documentId.length != 11) {
-    throw new Error('The provided document should have only 11 characters');
-  }
-
-  const c = documentId.split('');
-  const v = [1, 2, 1, 2, 1, 2, 1, 2, 1, 2];
-  let result = 0;
-  let oc;
-
-  for (let i = 0; i < 10; i++) {
-    const up = parseInt(c[i]) * v[i];
-    const ab = up;
-
-    if (ab >= 10) {
-      oc = ab
-        .toString()
-        .split('')
-        .map((x) => parseInt(x))
-        .reduce((x, y) => x + y);
-    } else {
-      oc = ab;
+    if (documentId.length !== 11) {
+      throw new Error('The provided document must have 11 characters.');
     }
 
-    result += oc;
-  }
-
-  let dp = result;
-  let ac: any = dp.toString().split('')[0] + '0';
-  ac = parseInt(ac);
-  const uj = (ac / 10) * 10;
-
-  if (uj < dp) {
-    // eslint-disable-next-line prettier/prettier
-    dp = uj + 10 - dp;
-  }
+    const digits = documentId.split('').map(Number);
+    const checkDigit = calculateDigits(digits.slice(0, 10));
 
-  const validationResult = c[10] == dp.toString();
-
-  if (validationResult) {
-    return true;
-  } else {
+    return checkDigit === digits[10];
+  } catch (error: any) {
+    console.error(error.message);
     return false;
   }
 }
@@ -62,3 +31,30 @@ function removeHyphens(documentId: string): string {
   }
   return documentId;
 }
+
+/**
+ * Calculates the check digit for a document number.
+ * @param {number[]} digits - The first 10 digits of the document.
+ * @returns {number} - The calculated check digit.
+ */
+function calculateDigits(digits: number[]): number {
+  const weights = [1, 2, 1, 2, 1, 2, 1, 2, 1, 2];
+  let sum = 0;
+
+  for (let i = 0; i < weights.length; i++) {
+    const product = digits[i] * weights[i];
+    sum += sumDigits(product);
+  }
+
+  const nextTen = Math.ceil(sum / 10) * 10;
+  return nextTen - sum;
+}
+
+/**
+ * Sums the digits of a number.
+ * @param {number} num - The number whose digits will be summed.
+ * @returns {number} - The sum of the digits of the number.
+ */
+function sumDigits(num: number): number {
+  return num.toString().split('').reduce((acc, digit) => acc + parseInt(digit), 0);
+}