Merge pull request #418 from DevKor-github/codexd/apply-release-branch-strategy

[codex] Apply release branch deployment strategy

Author: jjoonleo

.github/workflows/android-play-internal.yml

@@ -1,6 +1,9 @@
 name: Android Play Internal Deploy
 
 on:
+  push:
+    branches:
+      - main
   workflow_dispatch:
     inputs:
       release_notes:
@@ -15,7 +18,7 @@ jobs:
   deploy_internal:
     name: Build and upload internal testing draft
     runs-on: ubuntu-latest
-    environment: release
+    environment: staging
     env:
       ANDROID_KEYSTORE_PASSWORD: ${{ secrets.ANDROID_KEYSTORE_PASSWORD }}
       ANDROID_KEY_ALIAS: ${{ secrets.ANDROID_KEY_ALIAS }}
@@ -118,10 +121,11 @@ jobs:
           flutter build appbundle --release \
             --build-name="$ANDROID_BUILD_NAME" \
             --build-number="${{ github.run_number }}" \
+            --dart-define=ENV=staging \
             --dart-define=REST_API_URL="$REST_API_URL"
 
       - name: Prepare Play release notes
-        if: ${{ inputs.release_notes != '' }}
+        if: ${{ github.event_name == 'workflow_dispatch' && inputs.release_notes != '' }}
         env:
           RELEASE_NOTES: ${{ inputs.release_notes }}
         run: |
@@ -137,7 +141,7 @@ jobs:
           retention-days: 14
 
       - name: Upload internal testing draft with release notes
-        if: ${{ inputs.release_notes != '' }}
+        if: ${{ github.event_name == 'workflow_dispatch' && inputs.release_notes != '' }}
         uses: r0adkll/upload-google-play@v1
         with:
           serviceAccountJsonPlainText: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}
@@ -148,7 +152,7 @@ jobs:
           whatsNewDirectory: distribution/whatsnew
 
       - name: Upload internal testing draft
-        if: ${{ inputs.release_notes == '' }}
+        if: ${{ github.event_name != 'workflow_dispatch' || inputs.release_notes == '' }}
         uses: r0adkll/upload-google-play@v1
         with:
           serviceAccountJsonPlainText: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}

.github/workflows/android-release-verify.yml

@@ -1,6 +1,12 @@
 name: Android Release Verification
 
 on:
+  push:
+    branches:
+      - "release/**"
+      - "hotfix/**"
+    tags:
+      - "v*"
   workflow_dispatch:
 
 permissions:
@@ -11,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     environment: release
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/setup-java@v4
         with:
@@ -22,6 +28,7 @@ jobs:
         with:
           flutter-version: "3.32.6"
           channel: "stable"
+          cache: true
 
       - name: Decode Android Firebase config
         env:
@@ -37,7 +44,13 @@ jobs:
 
       - run: flutter pub get
 
-      - run: dart run build_runner build -d
+      - run: dart run build_runner build --delete-conflicting-outputs
+
+      - name: Analyze
+        run: flutter analyze
+
+      - name: Test
+        run: flutter test
 
       - name: Derive Android build name
         run: |
@@ -49,11 +62,20 @@ jobs:
           fi
           echo "ANDROID_BUILD_NAME=$build_name" >> "$GITHUB_ENV"
 
+      - name: Select app environment
+        run: |
+          app_env=staging
+          if [[ "$GITHUB_REF" == refs/tags/v* ]]; then
+            app_env=prod
+          fi
+          echo "APP_ENV=$app_env" >> "$GITHUB_ENV"
+
       - name: Build Android app bundle
         env:
           REST_API_URL: ${{ vars.REST_API_URL }}
         run: |
           flutter build appbundle --release \
             --build-name="$ANDROID_BUILD_NAME" \
             --build-number="${{ github.run_number }}" \
+            --dart-define=ENV="$APP_ENV" \
             --dart-define=REST_API_URL="$REST_API_URL"

.github/workflows/firebase-hosting-merge.yml

@@ -13,7 +13,7 @@ permissions:
 jobs:
   build_and_deploy:
     runs-on: ubuntu-latest
-    environment: release
+    environment: staging
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-java@v1
@@ -35,7 +35,10 @@ jobs:
       - name: Build Web
         env:
           REST_API_URL: ${{ vars.REST_API_URL }}
-        run: flutter build web --release --dart-define=REST_API_URL=$REST_API_URL
+        run: |
+          flutter build web --release \
+            --dart-define=ENV=staging \
+            --dart-define=REST_API_URL=$REST_API_URL
 
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:

.github/workflows/firebase-hosting-pull-request.yml

@@ -36,7 +36,10 @@ jobs:
       - name: Build Web
         env:
           REST_API_URL: ${{ vars.REST_API_URL }}
-        run: flutter build web --release --dart-define=REST_API_URL=$REST_API_URL
+        run: |
+          flutter build web --release \
+            --dart-define=ENV=dev \
+            --dart-define=REST_API_URL=$REST_API_URL
 
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:

.github/workflows/flutter_test.yml

@@ -2,22 +2,34 @@ name: Flutter Testing
 on:
   workflow_dispatch:
   pull_request:
-    branches: [main]
+    branches:
+      - main
+      - "release/**"
+      - "hotfix/**"
+  push:
+    branches:
+      - main
+      - "release/**"
+      - "hotfix/**"
 jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: subosito/flutter-action@v2
         with:
-          channel: 'stable'
+          flutter-version: "3.32.6"
+          channel: stable
+          cache: true
       - name: install sql
         run: sudo apt-get install sqlite3 libsqlite3-dev
       - name: Install packages
         run: flutter pub get
       - name: Check Flutter version
         run: flutter --version
       - name: Run generator
-        run: flutter pub run build_runner build
+        run: dart run build_runner build --delete-conflicting-outputs
+      - name: Analyze
+        run: flutter analyze
       - name: Run test
-        run: flutter test test
+        run: flutter test

README.md

@@ -81,6 +81,7 @@ The app reads compile-time values from Dart defines in `lib/core/constants/envir
 
 | Define | Required | Used for |
 | --- | --- | --- |
+| `ENV` | Optional | App environment label. Use `dev`, `staging`, or `prod`; defaults to `dev`. |
 | `REST_API_URL` | Yes | Base URL for Dio API calls. |
 | `REST_AUTH_TOKEN` | Optional | Static auth token override for development/test scenarios. |
 | `GOOGLE_RESERVED_CLIENT_ID_IOS` | iOS release/archive only | Reversed iOS Google client ID used as the iOS URL scheme for Google Sign-In. |
@@ -89,16 +90,19 @@ Pass defines directly on Flutter commands:
 
 ```sh
 flutter run -d chrome \
+  --dart-define=ENV=dev \
   --dart-define=REST_API_URL=<api-base-url>
 
 flutter build web --release \
+  --dart-define=ENV=staging \
   --dart-define=REST_API_URL=<api-base-url>
 ```
 
 For iOS release and archive builds, include the Google URL scheme define:
 
 ```sh
 flutter build ios --release \
+  --dart-define=ENV=prod \
   --dart-define=REST_API_URL=<api-base-url> \
   --dart-define=GOOGLE_RESERVED_CLIENT_ID_IOS=<reversed-ios-client-id>
 ```
@@ -165,19 +169,41 @@ flutter test --coverage
 Run the web app locally:
 
 ```sh
-flutter run -d chrome --dart-define=REST_API_URL=<api-base-url>
+flutter run -d chrome \
+  --dart-define=ENV=dev \
+  --dart-define=REST_API_URL=<api-base-url>
 ```
 
 Do not use `npm test`; the root `package.json` script is a placeholder that intentionally fails.
 
 ## Build and Release
 
+This repository uses trunk-based development with release branches:
+
+```text
+main = always test-deployable
+release/* = store candidate
+v* tag = production release source of truth
+hotfix/* = emergency production repair
+```
+
+Normal changes should land through short-lived `feature/*` or `fix/*` branches
+into `main`. Create `release/x.y.z` from `main` for final store QA, cut
+`vX.Y.Z` tags from approved release branches, then merge the release branch back
+to `main`. See [docs/Git.md](docs/Git.md) for the full branch and deployment
+flow.
+
 ### Web
 
-Preview and production web deployments are handled by GitHub Actions and Firebase Hosting. CI uses the `REST_API_URL` GitHub environment variable and builds with:
+Preview and staging web deployments are handled by GitHub Actions and Firebase
+Hosting. Pull requests build with `ENV=dev`; merges to `main` build with
+`ENV=staging`. CI uses the `REST_API_URL` GitHub environment variable and builds
+with:
 
 ```sh
-flutter build web --release --dart-define=REST_API_URL=<api-base-url>
+flutter build web --release \
+  --dart-define=ENV=staging \
+  --dart-define=REST_API_URL=<api-base-url>
 ```
 
 Firebase Hosting deploys `build/web` to project `ontime-c63f1`.
@@ -188,13 +214,15 @@ Build a release APK:
 
 ```sh
 flutter build apk --release \
+  --dart-define=ENV=staging \
   --dart-define=REST_API_URL=<api-base-url>
 ```
 
 Build an app bundle for Play Console upload:
 
 ```sh
 flutter build appbundle --release \
+  --dart-define=ENV=prod \
   --dart-define=REST_API_URL=<api-base-url>
 ```
 
@@ -206,6 +234,7 @@ Build locally:
 
 ```sh
 flutter build ios --release \
+  --dart-define=ENV=prod \
   --dart-define=REST_API_URL=<api-base-url> \
   --dart-define=GOOGLE_RESERVED_CLIENT_ID_IOS=<reversed-ios-client-id>
 ```

docs/Android-Release-Configuration.md

@@ -12,10 +12,11 @@ The release verification workflow decodes this secret to `android/app/src/releas
 
 Use the `Android Play Internal Deploy` GitHub Actions workflow to build a signed
 Android App Bundle and upload it to the Google Play Internal Testing track as a
-draft release. The workflow is manual-only and must be dispatched from `main`.
+draft release. The workflow runs automatically on pushes to `main` and can also
+be dispatched manually from `main`.
 
-Configure a GitHub environment named `release` with required reviewers before
-using the workflow. Store these environment secrets there:
+Configure a GitHub environment named `staging` for internal test distribution.
+Store these environment secrets there:
 
 - `ANDROID_GOOGLE_SERVICES_JSON_B64`: base64-encoded production Android
   Firebase config.
@@ -26,10 +27,9 @@ using the workflow. Store these environment secrets there:
 - `GOOGLE_PLAY_SERVICE_ACCOUNT_JSON`: raw service-account JSON for the Google
   Play Developer API.
 
-Store this environment variable in `release`:
+Store this environment variable in `staging`:
 
-- `REST_API_URL`: production API base URL passed to Flutter with
-  `--dart-define`.
+- `REST_API_URL`: target API base URL passed to Flutter with `--dart-define`.
 
 The deploy workflow runs package install, code generation, generated-file drift
 checking, analysis, tests, and then `flutter build appbundle --release`. It
@@ -40,6 +40,7 @@ derives Android `versionName` from the `pubspec.yaml` version name and supplies
 flutter build appbundle --release \
   --build-name=<version name from pubspec.yaml> \
   --build-number=${{ github.run_number }} \
+  --dart-define=ENV=staging \
   --dart-define=REST_API_URL="$REST_API_URL"
 ```
 
@@ -64,6 +65,7 @@ base64 --decode android-google-services.json.b64 > android/app/src/release/googl
 flutter build appbundle --release \
   --build-name=<version name from pubspec.yaml> \
   --build-number=<monotonic Android versionCode> \
+  --dart-define=ENV=prod \
   --dart-define=REST_API_URL=<api-url>
 ```