Skip to content

[codex] Show ready state after preparation completion#368

Merged
jjoonleo merged 2 commits into
mainfrom
codex/issue-364-ready-state
May 5, 2026
Merged

[codex] Show ready state after preparation completion#368
jjoonleo merged 2 commits into
mainfrom
codex/issue-364-ready-state

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a localized ready-state label for completed preparation before leave time.
  • Show the ready label instead of the last preparation step while continuing before the leave threshold.
  • Cover the ready state and late transition in the alarm preparation flow widget test.

Closes #364

Validation

  • flutter gen-l10n
  • dart format lib/l10n lib/presentation/alarm/screens/alarm_screen.dart test/presentation/alarm/screens/preparation_flow_widget_test.dart
  • flutter test test/presentation/alarm/screens/preparation_flow_widget_test.dart
  • dart analyze lib/presentation/alarm/screens/alarm_screen.dart lib/l10n test/presentation/alarm/screens/preparation_flow_widget_test.dart (only existing deprecated .value infos in the test file)

Notes

  • Full flutter analyze still reports pre-existing unrelated issues, including missing/generated Widgetbook files.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 810f321):

https://ontime-c63f1--pr368-codex-issue-364-read-8rmjzxe3.web.app

(expires Tue, 12 May 2026 06:10:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 810f321):

https://on-time-front-widgetbook--pr368-codex-issue-364-read-67r9c37l.web.app

(expires Tue, 12 May 2026 06:11:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo marked this pull request as ready for review May 5, 2026 06:11
@jjoonleo jjoonleo merged commit c8566e9 into main May 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show ready state after completing preparation before leave time

1 participant