Skip to content

[codex] Add spare time minimum warning#374

Merged
jjoonleo merged 1 commit into
mainfrom
codex/spare-time-minimum-bubble
May 5, 2026
Merged

[codex] Add spare time minimum warning#374
jjoonleo merged 1 commit into
mainfrom
codex/spare-time-minimum-bubble

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add the Figma-designed minimum warning bubble to the onboarding spare-time field.
  • Keep the spare-time input from decreasing below 10 minutes.
  • Add localized warning text and a Widgetbook use case for the spare-time field.
  • Tighten the shared error bubble layout so fixed-width message bubbles do not overflow.

Validation

  • dart analyze lib/presentation/shared/components/error_message_bubble.dart lib/presentation/onboarding/schedule_spare_time/components/shcedule_spare_time_field.dart widgetbook/lib/schedule_spare_time_field.dart
  • dart run build_runner build --delete-conflicting-outputs in widgetbook/
  • flutter analyze in widgetbook/

Note: root flutter analyze still reports existing unrelated warnings/infos outside these changes.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 7f32715):

https://ontime-c63f1--pr374-codex-spare-time-min-db0qb7uq.web.app

(expires Tue, 12 May 2026 16:18:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 7f32715):

https://on-time-front-widgetbook--pr374-codex-spare-time-min-kjxykjwx.web.app

(expires Tue, 12 May 2026 16:19:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo marked this pull request as ready for review May 5, 2026 16:23
@jjoonleo jjoonleo merged commit a0dee4b into main May 5, 2026
4 checks passed
@jjoonleo jjoonleo deleted the codex/spare-time-minimum-bubble branch May 6, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant