Skip to content

[codex] Support account deletion feedback#378

Merged
jjoonleo merged 1 commit into
mainfrom
codex/add-account-deletion-api
May 6, 2026
Merged

[codex] Support account deletion feedback#378
jjoonleo merged 1 commit into
mainfrom
codex/add-account-deletion-api

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • send optional withdrawal feedback in account deletion DELETE bodies
  • route normal, Google, and Apple account deletion through the correct backend endpoints
  • keep users signed in on deletion failure, and explicitly redirect to sign-in after successful deletion
  • add focused tests for deletion payloads and social account routing

Why

The backend now accepts optional feedback directly on account deletion requests. The previous frontend flow posted feedback separately and could sign users out even when deletion failed, which made social revoke errors look like successful withdrawal.

Validation

  • flutter analyze
  • flutter test test/data/data_sources/authentication_remote_data_source_test.dart test/domain/use-cases/delete_user_use_case_test.dart test/presentation/my_page/delete_user_modal_test.dart

@jjoonleo jjoonleo marked this pull request as ready for review May 6, 2026 17:59
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 2e4b121):

https://ontime-c63f1--pr378-codex-add-account-de-3fvd8okc.web.app

(expires Wed, 13 May 2026 18:02:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 2e4b121):

https://on-time-front-widgetbook--pr378-codex-add-account-de-p0qmmzup.web.app

(expires Wed, 13 May 2026 18:02:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo merged commit d07b1b0 into main May 6, 2026
4 checks passed
@jjoonleo jjoonleo deleted the codex/add-account-deletion-api branch May 6, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant