[codex] Fix schedule edit completion payload#380
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 0bde4fc): https://ontime-c63f1--pr380-codex-fix-schedule-e-rboov3n9.web.app (expires Wed, 13 May 2026 18:33:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3 |
|
Visit the preview URL for this PR (updated for commit 0bde4fc): https://on-time-front-widgetbook--pr380-codex-fix-schedule-e-8s6quwu5.web.app (expires Wed, 13 May 2026 18:34:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latenessTimefrom schedule update requests so ordinary edits do not send completion data.Root Cause
The edit flow built an update payload with
latenessTime: 0. Elsewhere in the app, finishing a schedule with lateness time0maps to a normal completion, so the backend could treat an edited schedule as finished. Finished schedules are delete-only in the detail UI and are filtered out of upcoming schedules.Validation
flutter test test/data/data_sources/schedule_remote_data_source_test.dart test/data/repositories/schedule_repository_impl_stream_test.dart test/domain/use-cases/get_nearest_upcoming_schedule_use_case_test.dartflutter analyze