Skip to content

[codex] Fix schedule edit completion payload#380

Merged
jjoonleo merged 1 commit into
mainfrom
codex/fix-schedule-edit-deletion-bug
May 6, 2026
Merged

[codex] Fix schedule edit completion payload#380
jjoonleo merged 1 commit into
mainfrom
codex/fix-schedule-edit-deletion-bug

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove latenessTime from schedule update requests so ordinary edits do not send completion data.
  • Restore schedule update remote data source tests and add a regression check that edit payloads omit completion fields.

Root Cause

The edit flow built an update payload with latenessTime: 0. Elsewhere in the app, finishing a schedule with lateness time 0 maps to a normal completion, so the backend could treat an edited schedule as finished. Finished schedules are delete-only in the detail UI and are filtered out of upcoming schedules.

Validation

  • flutter test test/data/data_sources/schedule_remote_data_source_test.dart test/data/repositories/schedule_repository_impl_stream_test.dart test/domain/use-cases/get_nearest_upcoming_schedule_use_case_test.dart
  • flutter analyze

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 0bde4fc):

https://ontime-c63f1--pr380-codex-fix-schedule-e-rboov3n9.web.app

(expires Wed, 13 May 2026 18:33:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 0bde4fc):

https://on-time-front-widgetbook--pr380-codex-fix-schedule-e-8s6quwu5.web.app

(expires Wed, 13 May 2026 18:34:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo marked this pull request as ready for review May 6, 2026 18:38
@jjoonleo jjoonleo merged commit fe4973f into main May 6, 2026
4 checks passed
@jjoonleo jjoonleo deleted the codex/fix-schedule-edit-deletion-bug branch May 6, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant