Skip to content

[codex] Fix schedule edit completion payload #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjoonleo merged 1 commit into from
May 6, 2026
Merged

[codex] Fix schedule edit completion payload #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/data/models/update_schedule_request_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ class UpdateScheduleRequestModel {
final int moveTime;
final int? scheduleSpareTime;
final String scheduleNote;
final int latenessTime;

const UpdateScheduleRequestModel({
required this.scheduleId,
Expand All @@ -24,7 +23,6 @@ class UpdateScheduleRequestModel {
required this.moveTime,
this.scheduleSpareTime,
required this.scheduleNote,
this.latenessTime = 0,
});

factory UpdateScheduleRequestModel.fromJson(Map<String, dynamic> json) =>
Expand All @@ -42,7 +40,6 @@ class UpdateScheduleRequestModel {
moveTime: entity.moveTime.inMinutes,
scheduleSpareTime: entity.scheduleSpareTime?.inMinutes,
scheduleNote: entity.scheduleNote,
latenessTime: entity.latenessTime,
);
}
}
84 changes: 42 additions & 42 deletions test/data/data_sources/schedule_remote_data_source_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'package:mockito/mockito.dart';
import 'package:on_time_front/core/constants/endpoint.dart';
import 'package:on_time_front/data/data_sources/schedule_remote_data_source.dart';
import 'package:on_time_front/data/models/create_schedule_request_model.dart';
import 'package:on_time_front/data/models/update_schedule_request_model.dart';
import 'package:on_time_front/domain/entities/place_entity.dart';
import 'package:on_time_front/domain/entities/schedule_entity.dart';
import 'package:uuid/uuid.dart';
Expand Down Expand Up @@ -36,6 +37,8 @@ void main() {

final tCreateScheduleModel =
CreateScheduleRequestModel.fromEntity(tScheduleEntity);
final tUpdateScheduleModel =
UpdateScheduleRequestModel.fromEntity(tScheduleEntity);

setUp(() {
dio = MockAppDio();
Expand Down Expand Up @@ -85,48 +88,45 @@ void main() {
});
});

// group('updateSchdule', () {
// test('should perform a PUT request on the /schedule/modify endpoint',
// () async {
// // arrange
// when(dio.put(Endpoint.updateSchedule(scheduleEntityId),
// data: tUpdateScheduleModel.toJson()))
// .thenAnswer(
// (_) async => Response(
// statusCode: 204,
// requestOptions:
// RequestOptions(path: Endpoint.updateSchedule(scheduleEntityId)),
// ),
// );

// // act
// await scheduleRemoteDataSourceImpl.updateSchedule(tScheduleEntity);

// // assert
// verify(dio.put(Endpoint.updateSchedule(scheduleEntityId),
// data: tUpdateScheduleModel.toJson()))
// .called(1);
// });

// test('should throw an exception when the response code is not 204',
// () async {
// when(dio.put(Endpoint.updateSchedule(scheduleEntityId),
// data: tUpdateScheduleModel.toJson()))
// .thenAnswer(
// (_) async => Response(
// statusCode: 400,
// requestOptions:
// RequestOptions(path: Endpoint.updateSchedule(scheduleEntityId)),
// ),
// );

// // act
// final call = scheduleRemoteDataSourceImpl.updateSchedule(tScheduleEntity);

// // assert
// expect(call, throwsException);
// });
// });
group('updateSchedule', () {
test('should perform a PUT request without completion fields', () async {
final updateJson = tUpdateScheduleModel.toJson();
expect(updateJson, isNot(contains('latenessTime')));

when(dio.put(Endpoint.updateSchedule(scheduleEntityId), data: updateJson))
.thenAnswer(
(_) async => Response(
statusCode: 200,
requestOptions:
RequestOptions(path: Endpoint.updateSchedule(scheduleEntityId)),
),
);

await scheduleRemoteDataSourceImpl.updateSchedule(tScheduleEntity);

verify(dio.put(Endpoint.updateSchedule(scheduleEntityId),
data: updateJson))
.called(1);
});

test('should throw an exception when the response code is not 200',
() async {
when(dio.put(
Endpoint.updateSchedule(scheduleEntityId),
data: tUpdateScheduleModel.toJson(),
)).thenAnswer(
(_) async => Response(
statusCode: 400,
requestOptions:
RequestOptions(path: Endpoint.updateSchedule(scheduleEntityId)),
),
);

final call = scheduleRemoteDataSourceImpl.updateSchedule(tScheduleEntity);

expect(call, throwsException);
});
});

group('deleteSchedule', () {
test('should perform a DELETE request on the /schedule/delete endpoint',
Expand Down
Loading