[codex] Fix Android calendar back navigation#381
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 16b3dec): https://ontime-c63f1--pr381-codex-fix-android-ba-9e5rhw8t.web.app (expires Wed, 13 May 2026 18:33:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3 |
|
Visit the preview URL for this PR (updated for commit 16b3dec): https://on-time-front-widgetbook--pr381-codex-fix-android-ba-torfofsz.web.app (expires Wed, 13 May 2026 18:34:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Android system back behavior on the calendar screen so pressing back returns to the home screen instead of closing the app.
Root Cause
The home calendar entry uses route replacement, so when
/calendaris the top-level location Android back has no prior route to pop and the app can terminate. The calendar app-bar back button already navigated to/home, but the system back path was not handled.Changes
_returnHome()helper for calendar back navigation.CalendarScreeninPopScopeto intercept Android back and route to/home./calendarand verifies the home route is shown.Validation
flutter test test/presentation/calendar/screens/calendar_screen_test.dartflutter analyze