Skip to content

[codex] Include iOS release dart defines#400

Merged
jjoonleo merged 1 commit into
mainfrom
feat/ios-release-dart-defines
May 7, 2026
Merged

[codex] Include iOS release dart defines#400
jjoonleo merged 1 commit into
mainfrom
feat/ios-release-dart-defines

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Include Dart-Defines.xcconfig in iOS release builds so plist substitutions match debug behavior.
  • Harden the Dart define extraction script and fail release/archive builds when GOOGLE_RESERVED_CLIENT_ID_IOS is missing.
  • Add a release-only Info.plist validation phase and document the required iOS release define.

Why

Release builds previously did not include the generated Dart define xcconfig, while Info.plist depends on $(GOOGLE_RESERVED_CLIENT_ID_IOS) for the Google Sign-In redirect scheme. That could produce release/archive apps with a missing or unresolved callback URL scheme.

Fixes #387

Validation

  • bash -n ios/scripts/extract_dart_defines.sh ios/scripts/validate_release_info_plist.sh
  • git diff --check
  • Verified release define extraction succeeds with GOOGLE_RESERVED_CLIENT_ID_IOS.
  • Verified missing release define fails with the intended error.
  • Verified release Info.plist validation passes/fails against sample plists.
  • xcodebuild -list -project ios/Runner.xcodeproj
  • Attempted release simulator build after flutter pub get and pod install; it reached native pod compilation and then stopped with No space left on device.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 65c71c5):

https://ontime-c63f1--pr400-feat-ios-release-dar-kp9lfm6y.web.app

(expires Thu, 14 May 2026 05:30:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 65c71c5):

https://on-time-front-widgetbook--pr400-feat-ios-release-dar-hhfn4ard.web.app

(expires Thu, 14 May 2026 05:30:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo marked this pull request as ready for review May 7, 2026 05:43
@jjoonleo jjoonleo merged commit fca3c6a into main May 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Production readiness] Include Dart defines in iOS release configuration

1 participant