Skip to content

Normalize preparation step order before alarm rendering#405

Merged
jjoonleo merged 2 commits into
mainfrom
codexd/fix-alarm-screen-step-order
May 7, 2026
Merged

Normalize preparation step order before alarm rendering#405
jjoonleo merged 2 commits into
mainfrom
codexd/fix-alarm-screen-step-order

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added a canonical ordered view on PreparationEntity that follows the nextPreparationId chain.
  • Applied that ordering when converting preparation data for the alarm flow, so the alarm screen matches the actual schedule sequence.
  • Added regression coverage for both remote preparation parsing and timing conversion.

Testing

  • flutter test test/data/data_sources/preparation_remote_data_source_test.dart
  • flutter test test/domain/entities/preparation_timing_entity_test.dart

jjoonleo added 2 commits May 7, 2026 23:02
…en-step-order

# Conflicts:
#	lib/data/models/get_preparation_step_response_model.dart
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 62d0fdb):

https://ontime-c63f1--pr405-codexd-fix-alarm-scr-cymki5fy.web.app

(expires Thu, 14 May 2026 14:11:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 62d0fdb):

https://on-time-front-widgetbook--pr405-codexd-fix-alarm-scr-1hwrl6nr.web.app

(expires Thu, 14 May 2026 14:11:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo marked this pull request as ready for review May 7, 2026 14:12
@jjoonleo jjoonleo merged commit 3721a64 into main May 7, 2026
4 checks passed
@jjoonleo jjoonleo deleted the codexd/fix-alarm-screen-step-order branch May 7, 2026 14:12
@jjoonleo jjoonleo restored the codexd/fix-alarm-screen-step-order branch May 7, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant