[codex] Enforce Android Firebase release config#408
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 1f4e365): https://ontime-c63f1--pr408-codexd-android-fireb-bre4mvb5.web.app (expires Thu, 14 May 2026 14:14:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3 |
|
Visit the preview URL for this PR (updated for commit 1f4e365): https://on-time-front-widgetbook--pr408-codexd-android-fireb-kx512qcd.web.app (expires Thu, 14 May 2026 14:15:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google-services.jsonconfig instead of silently skipping Google Services.ANDROID_GOOGLE_SERVICES_JSON_B64and builds the release app bundle.Why
Issue #386 identified that release builds could compile without the Android Firebase client config, leaving Firebase Core and FCM behavior dependent on local/CI filesystem state.
Validation
flutter analyzeflutter testflutter build apk --debugwithout Android Firebase configflutter build appbundle --releasewithout Android Firebase config, confirmed it fails with the intended Gradle errorNotes
Release success and real-device FCM registration still require the approved production
google-services.json/ANDROID_GOOGLE_SERVICES_JSON_B64secret.