[codex] Derive Android version code from run number#417
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 8adf7a3): https://ontime-c63f1--pr417-codexd-android-run-n-u8gkmt7d.web.app (expires Fri, 15 May 2026 16:22:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3 |
|
Visit the preview URL for this PR (updated for commit 8adf7a3): https://on-time-front-widgetbook--pr417-codexd-android-run-n-dd2jxvbc.web.app (expires Fri, 15 May 2026 16:23:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionNamefrompubspec.yamlin release workflows.github.run_numberas the generated AndroidversionCodefor Play upload and release verification builds.pubspec.yamlto1.0.0+1and update Android release docs so future redeploys do not require PRs that only bump+2,+3, etc.Why
Google Play requires a monotonically increasing Android
versionCode, but checked-in Flutter build suffix bumps create noisy PRs. Using the workflow run number keeps CI uploads monotonic while leaving the public version name manually controlled inpubspec.yaml.Validation
.github/workflows/android-play-internal.yml,.github/workflows/android-release-verify.yml, andpubspec.yamlwith Ruby YAML.git diff --check.1.0.0+1to Android build name1.0.0.