Skip to content

Refactor core service dependencies#568

Merged
jjoonleo merged 2 commits into
mainfrom
feature/issue-528-core-service-dependencies
Jun 28, 2026
Merged

Refactor core service dependencies#568
jjoonleo merged 2 commits into
mainfrom
feature/issue-528-core-service-dependencies

Conversation

@jjoonleo

Copy link
Copy Markdown
Contributor

Summary

  • inject TokenInterceptor token/session collaborators through AppDio instead of resolving them with getIt
  • delegate NotificationService FCM token registration and tap routing through explicit seams
  • add concrete FCM registration and navigation tap router tests

Tests

  • dart run build_runner build --delete-conflicting-outputs
  • flutter test test/core/dio/interceptors/token_interceptor_test.dart test/core/dio/transformers/logging_transformer_test.dart test/core/services/notification_service_test.dart test/core/services/notification_tap_router_test.dart test/data/services/device_fcm_token_registrar_test.dart test/core/services/fallback_alarm_notification_service_test.dart
  • flutter analyze
  • flutter test

Closes #528

@jjoonleo jjoonleo merged commit 8a0a3a4 into main Jun 28, 2026
1 of 4 checks passed
@jjoonleo jjoonleo deleted the feature/issue-528-core-service-dependencies branch June 28, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor core services to remove hidden getIt data, repository, and navigation dependencies

1 participant