Skip to content

refactor(report): 공유 상태 조회 시 리포트 없을 때 예외 대신 false 반환 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coldsunn merged 1 commit into from
Mar 8, 2026
Merged

refactor(report): 공유 상태 조회 시 리포트 없을 때 예외 대신 false 반환 #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/main/java/com/devkor/ifive/nadab/domain/dailyreport/application/FeedQueryService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,13 @@
import com.devkor.ifive.nadab.domain.dailyreport.api.dto.response.FeedResponse;
import com.devkor.ifive.nadab.domain.dailyreport.api.dto.response.FeedListResponse;
import com.devkor.ifive.nadab.domain.dailyreport.api.dto.response.ShareStatusResponse;
import com.devkor.ifive.nadab.domain.dailyreport.core.entity.DailyReport;
import com.devkor.ifive.nadab.domain.dailyreport.core.repository.DailyReportRepository;
import com.devkor.ifive.nadab.domain.dailyreport.core.dto.FeedDto;
import com.devkor.ifive.nadab.domain.friend.core.entity.Friendship;
import com.devkor.ifive.nadab.domain.friend.core.entity.FriendshipStatus;
import com.devkor.ifive.nadab.domain.friend.core.repository.FriendshipRepository;
import com.devkor.ifive.nadab.domain.user.core.entity.DefaultProfileType;
import com.devkor.ifive.nadab.domain.user.infra.ProfileImageUrlBuilder;
import com.devkor.ifive.nadab.global.core.response.ErrorCode;
import com.devkor.ifive.nadab.global.exception.NotFoundException;
import com.devkor.ifive.nadab.global.shared.util.TodayDateTimeProvider;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
Expand Down Expand Up @@ -70,12 +67,10 @@ public FeedListResponse getFeeds(Long userId) {
}

public ShareStatusResponse getShareStatus(Long userId) {
// 1. 당일 DailyReport 조회
LocalDate today = TodayDateTimeProvider.getTodayDate();
DailyReport report = dailyReportRepository.findByUserIdAndDate(userId, today)
.orElseThrow(() -> new NotFoundException(ErrorCode.DAILY_REPORT_NOT_FOUND));

return new ShareStatusResponse(report.getIsShared());
return dailyReportRepository.findByUserIdAndDate(userId, today)
.map(report -> new ShareStatusResponse(report.getIsShared()))
.orElse(new ShareStatusResponse(false));
}

private String buildProfileUrl(String profileImageKey, DefaultProfileType defaultProfileType) {
Expand Down