Skip to content

Commit 29105e1

Browse files
authored
feat(): 답글 알림의 relatedId를 collectionId로 변경 (#295)
* feat: 답글 푸시 알림의 relatedId를 collectionId로 변경 * ci(infra): 깃허브 워크플로우에 테스트 컨테이너 최소 api 버전 명시
1 parent 6e66ebc commit 29105e1

4 files changed

Lines changed: 15 additions & 1 deletion

File tree

.github/workflows/deploy-to-dev-ec2.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ jobs:
2222
- name: Grant execute permission for Gradle
2323
run: chmod +x gradlew
2424

25+
- name: Fix Docker API compatibility for Testcontainers
26+
run: echo 'api.version=1.44' > ~/.docker-java.properties
27+
2528
- name: Build with Gradle
2629
run: ./gradlew test bootJar
2730

.github/workflows/deploy-to-prod-ec2.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ jobs:
2222
- name: Grant execute permission for Gradle
2323
run: chmod +x gradlew
2424

25+
- name: Fix Docker API compatibility for Testcontainers
26+
run: echo 'api.version=1.44' > ~/.docker-java.properties
27+
2528
- name: Build with Gradle
2629
run: ./gradlew test bootJar
2730

.github/workflows/run-tests-on-pull-request-to-develop.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,8 @@ jobs:
2222
- name: Grant execute permission for Gradle
2323
run: chmod +x gradlew
2424

25+
- name: Fix Docker API compatibility for Testcontainers
26+
run: echo 'api.version=1.44' > ~/.docker-java.properties
27+
2528
- name: Run tests
2629
run: ./gradlew test

src/main/java/org/devkor/apu/saerok_server/domain/notification/application/facade/NotifyActionDsl.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.devkor.apu.saerok_server.domain.notification.application.model.dsl.ActionKind;
55
import org.devkor.apu.saerok_server.domain.notification.application.model.dsl.Actor;
66
import org.devkor.apu.saerok_server.domain.notification.application.model.dsl.Target;
7+
import org.devkor.apu.saerok_server.domain.notification.application.model.dsl.TargetType;
78
import org.devkor.apu.saerok_server.domain.notification.application.model.payload.ActionNotificationPayload;
89
import org.devkor.apu.saerok_server.domain.notification.application.port.TargetMetadataPort;
910
import org.devkor.apu.saerok_server.domain.notification.core.entity.NotificationAction;
@@ -111,14 +112,18 @@ public void to(Long recipientId) {
111112
case SUGGEST_BIRD_ID -> NotificationAction.SUGGEST_BIRD_ID;
112113
};
113114

115+
Long relatedId = target.type() == TargetType.COMMENT && extras.containsKey("collectionId")
116+
? (Long) extras.get("collectionId")
117+
: target.id();
118+
114119
publisher.push(
115120
new ActionNotificationPayload(
116121
recipientId,
117122
actor.id(),
118123
actor.name(),
119124
notificationSubject,
120125
notificationAction,
121-
target.id(),
126+
relatedId,
122127
extras
123128
)
124129
);

0 commit comments

Comments
 (0)