Skip to content

fix: correct login redirect and improve i18n UX in quiz flow #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorSvertoka merged 1 commit into from
Jan 11, 2026
Merged

fix: correct login redirect and improve i18n UX in quiz flow #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion frontend/components/quiz/CountdownTimer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,15 @@ export function CountdownTimer({

{percentage <= 30 && (
<p className="text-xs mt-2 font-medium">
{percentage <= 10 ? t('almostDone') : t('hurryUp')}
{percentage <= 10 ? (
<>
<span aria-hidden="true">⚠️</span> {t('almostDone')}
</>
) : (
<>
<span aria-hidden="true">⏰</span> {t('hurryUp')}
</>
)}
</p>
)}
</div>
Expand Down
12 changes: 5 additions & 7 deletions frontend/components/quiz/QuizResult.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export function QuizResult({
{violationsCount >= 3 && (
<div className="p-4 rounded-xl bg-orange-50 dark:bg-orange-900/20 border border-orange-200 dark:border-orange-800">
<p className="text-center text-orange-800 dark:text-orange-200 font-medium">
{t('violations', { count: violationsCount })}
<span aria-hidden="true">⚠️</span> {t('violations', { count: violationsCount })}
</p>
</div>
)}
Expand Down Expand Up @@ -140,12 +140,10 @@ export function QuizResult({
<div className="flex flex-col sm:flex-row gap-3 justify-center">
<Button
onClick={() => {
const url = `/${locale}/signup?returnTo=/quiz/${quizSlug}`;
console.log('Navigating to signup:', url);
window.location.href = url;
}}
variant="primary"
>
const url = `/${locale}/login?returnTo=/quiz/${quizSlug}`;
window.location.href = url;
}}
variant="primary">
{t('loginButton')}
</Button>
<Button
Expand Down
6 changes: 3 additions & 3 deletions frontend/messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@
},
"timer": {
"label": "Time remaining:",
"almostDone": "⚠️ Time almost up!",
"hurryUp": "⏰ Hurry up!"
"almostDone": "Time is almost up!",
"hurryUp": "Hurry up!"
},
"result": {
"correctAnswers": "correct answers",
Expand All @@ -128,7 +128,7 @@
"title": "Excellent Work!",
"message": "You have mastered the material well"
},
"violations": "⚠️ Quiz completed with rule violations ({count} violations). Result not counted towards leaderboard.",
"violations": "Quiz completed with rule violations ({count} violations). Result not counted towards leaderboard.",
"pointsAwarded": "+{points} points added to rating",
"noPointsAwarded": "No points awarded (result not improved)",
"guestMessage": "To save your result and appear on the leaderboard, log in or sign up",
Expand Down
6 changes: 3 additions & 3 deletions frontend/messages/pl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@
},
"timer": {
"label": "Pozostały czas:",
"almostDone": "⚠️ Czas prawie minął!",
"hurryUp": "⏰ Pośpiesz się!"
"almostDone": "Czas prawie minął!",
"hurryUp": "Pośpiesz się!"
},
"result": {
"correctAnswers": "prawidłowych odpowiedzi",
Expand All @@ -128,7 +128,7 @@
"title": "Doskonała Praca!",
"message": "Dobrze opanowałeś materiał"
},
"violations": "⚠️ Quiz ukończony z naruszeniami zasad ({count} naruszeń). Wynik nie zaliczony do rankingu.",
"violations": "Quiz ukończony z naruszeniami zasad ({count} naruszeń). Wynik nie zaliczony do rankingu.",
"pointsAwarded": "+{points} punktów dodanych do oceny",
"noPointsAwarded": "Nie przyznano punktów (wynik nie poprawiony)",
"guestMessage": "Aby zapisać wynik i pojawić się w rankingu, zaloguj się lub zarejestruj",
Expand Down
6 changes: 3 additions & 3 deletions frontend/messages/uk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@
},
"timer": {
"label": "Залишилось часу:",
"almostDone": "⚠️ Час майже закінчився!",
"hurryUp": "⏰ Поспішайте!"
"almostDone": "Час майже закінчився!",
"hurryUp": "Поспішайте!"
},
"result": {
"correctAnswers": "правильних відповідей",
Expand All @@ -128,7 +128,7 @@
"title": "Чудова робота!",
"message": "Ви добре засвоїли матеріал"
},
"violations": "⚠️ Квіз завершено з порушеннями правил ({count} порушень). Результат не зараховано до рейтингу.",
"violations": "Квіз завершено з порушеннями правил ({count} порушень). Результат не зараховано до рейтингу.",
"pointsAwarded": "+{points} балів додано до рейтингу",
"noPointsAwarded": "Бали не нараховано (результат не покращено)",
"guestMessage": "Щоб зберегти результат та потрапити в рейтинг, увійдіть або зареєструйтесь",
Expand Down