fix(redis): fix indentation in getRedisClient

[LesiaUKR]

Summary by CodeRabbit

• Chores
  • Improved environment/configuration validation for the Redis connection. If the connection URL or token are missing or malformed, Redis will be gracefully disabled to prevent runtime errors and improve stability.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
devlovers-net	Ignored	Preview	Mar 29, 2026 6:55pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0e8d1c28-21d3-4eb4-9ea3-47c69a32bee2

📥 Commits

Reviewing files that changed from the base of the PR and between 83eee23 and c262b72.

📒 Files selected for processing (1)

• frontend/lib/redis.ts

---

📝 Walkthrough

Walkthrough

The Redis client now reads UPSTASH_REDIS_REST_URL and UPSTASH_REDIS_REST_TOKEN individually via readServerEnv('...'), returns null if either is missing, and additionally validates the URL by attempting new URL(...), returning null when parsing fails. Client creation and caching remain unchanged.

Changes

Cohort / File(s)	Summary
Redis Configuration frontend/lib/redis.ts	Switched env retrieval to readServerEnv('UPSTASH_REDIS_REST_URL') and readServerEnv('UPSTASH_REDIS_REST_TOKEN') instead of destructuring from getServerEnv(). Added null-checks for missing values and URL parsing validation using new URL(...), returning null on parse failure. Redis client creation/caching logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I nibble env vars, one by one,
A tidy hop, a parse well done,
If URL trips, I timeout slow—
Then back to burrow, soft and low. 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title claims the PR fixes indentation, but the summary shows the actual changes involve refactoring how environment variables are imported and read, from using getServerEnv() to using readServerEnv(). The indentation fix appears to be incidental, not the main change.	Update the title to accurately reflect the main change: 'refactor(redis): use readServerEnv for environment variables' or similar to describe the actual refactoring work done.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/redis-indent

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@frontend/lib/redis.ts`:
- Around line 10-15: The guard in frontend/lib/redis.ts now only checks that
UPSTASH_REDIS_REST_URL and UPSTASH_REDIS_REST_TOKEN are non-empty (via
readServerEnv) but no longer validates that UPSTASH_REDIS_REST_URL is a
well-formed URL; update the early-return logic to validate
UPSTASH_REDIS_REST_URL (e.g., using the same URL validation used before or by
constructing new URL(UPSTASH_REDIS_REST_URL) and catching errors) and return
null only if the URL is missing or invalid so callers like redis.get in
frontend/lib/cache/qa.ts fail fast on misconfigured deploys; reference the
constant UPSTASH_REDIS_REST_URL and the readServerEnv call in this file when
making the change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 28459843-50c8-4d78-b9f5-f9c60b99a1ab

📥 Commits

Reviewing files that changed from the base of the PR and between ed04413 and 83eee23.

📒 Files selected for processing (1)

• frontend/lib/redis.ts