Skip to content

Commit 1081a43

Browse files
Yang Ligregkh
authored andcommitted
ethtool: Fix an error code in cxgb2.c
[ Upstream commit 7db8263a12155c7ae4ad97e850f1e499c73765fc ] When adapter->registered_device_map is NULL, the value of err is uncertain, we set err to -EINVAL to avoid ambiguity. Clean up smatch warning: drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing error code 'err' Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 33920b6 commit 1081a43

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

  • drivers/net/ethernet/chelsio/cxgb

drivers/net/ethernet/chelsio/cxgb/cxgb2.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1133,6 +1133,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
11331133
if (!adapter->registered_device_map) {
11341134
pr_err("%s: could not register any net devices\n",
11351135
pci_name(pdev));
1136+
err = -EINVAL;
11361137
goto out_release_adapter_res;
11371138
}
11381139

0 commit comments

Comments
 (0)