Skip to content

Commit 41d5dfa

Browse files
BK1603gregkh
authored andcommitted
ip_gre: add validation for csum_start
[ Upstream commit 1d011c4803c72f3907eccfc1ec63caefb852fcbf ] Validate csum_start in gre_handle_offloads before we call _gre_xmit so that we do not crash later when the csum_start value is used in the lco_csum function call. This patch deals with ipv4 code. Fixes: c544193 ("GRE: Refactor GRE tunneling code.") Reported-by: syzbot+ff8e1b9f2f36481e2efc@syzkaller.appspotmail.com Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com> Reviewed-by: Willem de Bruijn <willemb@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 8421250 commit 41d5dfa

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

net/ipv4/ip_gre.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,8 @@ static void __gre_xmit(struct sk_buff *skb, struct net_device *dev,
353353

354354
static int gre_handle_offloads(struct sk_buff *skb, bool csum)
355355
{
356+
if (csum && skb_checksum_start(skb) < skb->data)
357+
return -EINVAL;
356358
return iptunnel_handle_offloads(skb, csum ? SKB_GSO_GRE_CSUM : SKB_GSO_GRE);
357359
}
358360

0 commit comments

Comments
 (0)