Skip to content

Commit 8448dd6

Browse files
Bikram GoleBikram Gole
authored andcommitted
Move theme changer into hamburger menu; fix name-speak button size on mobile
1 parent f2f9b7b commit 8448dd6

4 files changed

Lines changed: 49 additions & 27 deletions

File tree

about.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,7 @@
6363
<a href="index.html" data-nav="home">Home</a>
6464
<a href="about.html" data-nav="about">About</a>
6565
<a href="contact.html" data-nav="contact">Contact</a>
66-
</nav>
67-
<button class="hamburger" type="button" aria-label="Menu" aria-expanded="false">
68-
<span class="hamburger-line"></span>
69-
<span class="hamburger-line"></span>
70-
<span class="hamburger-line"></span>
71-
</button>
72-
<div class="header-tools">
66+
<div class="header-tools">
7367
<label for="header-theme-select" class="theme-top-label">Theme</label>
7468
<select id="header-theme-select" class="theme-top-select" aria-label="Theme switcher">
7569
<option value="mint">Mint Matrix</option>
@@ -89,7 +83,13 @@
8983
<option value="blackflag">Black Flag Uprising</option>
9084
</select>
9185
<button id="theme-cycle-btn" class="theme-cycle-btn" type="button" aria-label="Cycle theme"></button>
92-
</div>
86+
</div>
87+
</nav>
88+
<button class="hamburger" type="button" aria-label="Menu" aria-expanded="false">
89+
<span class="hamburger-line"></span>
90+
<span class="hamburger-line"></span>
91+
<span class="hamburger-line"></span>
92+
</button>
9393
</header>
9494
<div class="scroll-progress" aria-hidden="true">
9595
<span class="scroll-progress-bar"></span>

contact.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,7 @@
6363
<a href="index.html" data-nav="home">Home</a>
6464
<a href="about.html" data-nav="about">About</a>
6565
<a href="contact.html" data-nav="contact">Contact</a>
66-
</nav>
67-
<button class="hamburger" type="button" aria-label="Menu" aria-expanded="false">
68-
<span class="hamburger-line"></span>
69-
<span class="hamburger-line"></span>
70-
<span class="hamburger-line"></span>
71-
</button>
72-
<div class="header-tools">
66+
<div class="header-tools">
7367
<label for="header-theme-select" class="theme-top-label">Theme</label>
7468
<select id="header-theme-select" class="theme-top-select" aria-label="Theme switcher">
7569
<option value="mint">Mint Matrix</option>
@@ -89,7 +83,13 @@
8983
<option value="blackflag">Black Flag Uprising</option>
9084
</select>
9185
<button id="theme-cycle-btn" class="theme-cycle-btn" type="button" aria-label="Cycle theme"></button>
92-
</div>
86+
</div>
87+
</nav>
88+
<button class="hamburger" type="button" aria-label="Menu" aria-expanded="false">
89+
<span class="hamburger-line"></span>
90+
<span class="hamburger-line"></span>
91+
<span class="hamburger-line"></span>
92+
</button>
9393
</header>
9494
<div class="scroll-progress" aria-hidden="true">
9595
<span class="scroll-progress-bar"></span>

index.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,7 @@
8181
<a href="index.html" data-nav="home">Home</a>
8282
<a href="about.html" data-nav="about">About</a>
8383
<a href="contact.html" data-nav="contact">Contact</a>
84-
</nav>
85-
<button class="hamburger" type="button" aria-label="Menu" aria-expanded="false">
86-
<span class="hamburger-line"></span>
87-
<span class="hamburger-line"></span>
88-
<span class="hamburger-line"></span>
89-
</button>
90-
<div class="header-tools">
84+
<div class="header-tools">
9185
<label for="header-theme-select" class="theme-top-label">Theme</label>
9286
<select id="header-theme-select" class="theme-top-select" aria-label="Theme switcher">
9387
<option value="mint">Mint Matrix</option>
@@ -107,7 +101,13 @@
107101
<option value="blackflag">Black Flag Uprising</option>
108102
</select>
109103
<button id="theme-cycle-btn" class="theme-cycle-btn" type="button" aria-label="Cycle theme"></button>
110-
</div>
104+
</div>
105+
</nav>
106+
<button class="hamburger" type="button" aria-label="Menu" aria-expanded="false">
107+
<span class="hamburger-line"></span>
108+
<span class="hamburger-line"></span>
109+
<span class="hamburger-line"></span>
110+
</button>
111111
</header>
112112
<div class="scroll-progress" aria-hidden="true">
113113
<span class="scroll-progress-bar"></span>

styles.css

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5482,6 +5482,16 @@ body[data-page="home"] .github-layout {
54825482
}
54835483
}
54845484

5485+
/* Nav contains header-tools on desktop */
5486+
.site-header nav {
5487+
flex: 1;
5488+
align-items: center;
5489+
}
5490+
5491+
.site-header nav .header-tools {
5492+
margin-left: auto;
5493+
}
5494+
54855495
/* Hamburger Menu */
54865496
.hamburger {
54875497
display: none;
@@ -5561,6 +5571,19 @@ body[data-page="home"] .github-layout {
55615571
padding: 0.6rem 1.2rem;
55625572
}
55635573

5574+
.site-header nav .header-tools {
5575+
margin-left: 0;
5576+
flex-direction: row;
5577+
gap: 0.5rem;
5578+
width: auto;
5579+
justify-content: center;
5580+
margin-top: 0.8rem;
5581+
}
5582+
5583+
.site-header nav .header-tools .theme-top-label {
5584+
display: inline;
5585+
}
5586+
55645587
.hero-name-row {
55655588
flex-wrap: nowrap;
55665589
}
@@ -5586,9 +5609,8 @@ body[data-page="home"] .github-layout {
55865609
}
55875610

55885611
.name-speak {
5589-
width: 44px !important;
5590-
height: 44px !important;
5591-
right: -0.5rem !important;
5612+
width: 36px;
5613+
height: 36px;
55925614
}
55935615

55945616
#command-input,

0 commit comments

Comments
 (0)