Skip to content

Commit 0286006

Browse files
Update pxt-programming-docs-buildpush.yml
1 parent f9c5bd6 commit 0286006

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

.github/workflows/pxt-programming-docs-buildpush.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ name: pxt-buildpush
33
on:
44
push:
55
branches:
6-
- '**' # Run workflow when any branch is updated
6+
- '**'
77
tags:
8-
- '*' # Run workflow when any new tag is pushed
8+
- '*'
99
pull_request:
1010
branches:
11-
- '**' # Run workflow for pull requests targeting any branch
11+
- '**'
1212

1313
permissions:
1414
contents: write
@@ -20,13 +20,15 @@ jobs:
2020
tag-bump-commit:
2121
uses: ./.github/workflows/tag-bump-commit.yml
2222
needs: filter-vtags
23-
if: fromJSON(needs.filter-vtags.outputs.is_vtag || 'false') == false
23+
# Run only when NOT a vtag
24+
if: needs.filter-vtags.outputs.is_vtag != 'true'
2425

2526
buildpush:
2627
name: buildpush
2728
runs-on: ubuntu-latest
2829
needs: tag-bump-commit
29-
if: always() && fromJSON(needs.tag-bump-commit.outputs.did_tag || 'false') == false
30+
# Run only when tag-bump-commit did NOT create a tag
31+
if: always() && needs.tag-bump-commit.outputs.did_tag != 'true'
3032
steps:
3133
- uses: actions/checkout@main
3234
with:
@@ -48,19 +50,18 @@ jobs:
4850
npm install
4951
5052
- name: pxt ci (without publish capability)
51-
run: |
52-
pxt ci
53+
run: pxt ci
5354
env:
5455
CHROME_BIN: chromium-browser
5556
DISPLAY: :99.0
5657
CI: true
5758

5859
buildvtag:
59-
# This job is a duplicate of pxt-buildvtag.yml's workflow
6060
name: buildvtag
6161
runs-on: ubuntu-latest
6262
needs: tag-bump-commit
63-
if: always() && fromJSON(needs.tag-bump-commit.outputs.did_tag || 'false') == true
63+
# Run only when tag-bump-commit DID create a tag
64+
if: always() && needs.tag-bump-commit.outputs.did_tag == 'true'
6465
steps:
6566
- uses: actions/checkout@main
6667
with:
@@ -90,8 +91,7 @@ jobs:
9091
path: node_modules/pxt-arcade-sim
9192

9293
- name: pxt ci (with publish capability)
93-
run: |
94-
pxt ci --publish
94+
run: pxt ci --publish
9595
env:
9696
NPM_PUBLISH: true
9797
CHROME_BIN: chromium-browser

0 commit comments

Comments
 (0)