Merge pull request #52 from DeveloperTryingToCodeLikeOtherOfThem/DeveloperTryingToCodeLikeOtherOfThem-patch-19

Update pxt-programming-docs-buildpush.yml

Author: DeveloperTryingToCodeLikeOtherOfThem

.github/workflows/pxt-programming-docs-buildpush.yml

@@ -1,17 +1,118 @@
+# name: pxt-buildpush
+
+# on:
+#   push:
+#     branches:
+#       - '**'
+#     tags:
+#       - '*'
+#   pull_request:
+#     branches:
+#       - '**'
+
+# permissions:
+#   contents: write
+
+# jobs:
+#   filter-vtags:
+#     uses: ./.github/workflows/is-vtag.yml
+
+#   tag-bump-commit:
+#     uses: ./.github/workflows/tag-bump-commit.yml
+#     needs: filter-vtags
+#     # Run only when NOT a vtag
+#     if: needs.filter-vtags.outputs.is_vtag != 'true'
+
+#   buildpush:
+#     name: buildpush
+#     runs-on: ubuntu-latest
+#     needs: tag-bump-commit
+#     # Run only when tag-bump-commit did NOT create a tag
+#     if: always() && needs.tag-bump-commit.outputs.did_tag != 'true'
+#     steps:
+#       - uses: actions/checkout@main
+#         with:
+#           fetch-depth: 0
+#           fetch-tags: true
+
+#       - name: Use Node.js
+#         uses: actions/setup-node@main
+#         with:
+#           node-version: 20.x
+
+#       - name: Update npm
+#         run: npm install -g npm@latest
+
+#       - name: npm install
+#         run: |
+#           sudo apt-get install xvfb
+#           sudo npm install -g pxt
+#           npm install
+
+#       # - name: pxt ci (without publish capability)
+#       #   run: pxt ci
+#       #   env:
+#       #     CHROME_BIN: chromium-browser
+#       #     DISPLAY: :99.0
+#       #     CI: true
+#       # unsupported
+
+#   buildvtag:
+#     name: buildvtag
+#     runs-on: ubuntu-latest
+#     needs: tag-bump-commit
+#     # Run only when tag-bump-commit DID create a tag
+#     if: always() && needs.tag-bump-commit.outputs.did_tag == 'true'
+#     steps:
+#       - uses: actions/checkout@main
+#         with:
+#           fetch-depth: 0
+#           fetch-tags: true
+
+#       - name: Use Node.js
+#         uses: actions/setup-node@main
+#         with:
+#           node-version: 20.x
+
+#       - name: Update npm
+#         run: npm install -g npm@latest
+
+#       - name: npm install
+#         run: |
+#           sudo apt-get install xvfb
+#           sudo npm install -g pxt
+#           npm install
+
+#       - name: Checkout pxt-arcade-sim
+#         uses: actions/checkout@v5
+#         with:
+#           repository: microsoft/pxt-arcade-sim
+#           ref: v0.12.3
+#           ssh-key: ${{ secrets.SIM_DEPLOY_KEY }}
+#           path: node_modules/pxt-arcade-sim
+
+#       - name: pxt ci (with publish capability)
+#         run: pxt ci --publish
+#         env:
+#           NPM_PUBLISH: true
+#           CHROME_BIN: chromium-browser
+#           DISPLAY: :99.0
+#           CI: true
 name: pxt-buildpush
 
 on:
   push:
     branches:
-      - '**'
+      - '**' # Run workflow when any branch is updated
     tags:
-      - '*'
+      - '*'  # Run workflow when any new tag is pushed
   pull_request:
     branches:
-      - '**'
+      - '**' # Run workflow for pull requests targeting any branch
 
 permissions:
   contents: write
+  id-token: write  # Required for OIDC
 
 jobs:
   filter-vtags:
@@ -20,15 +121,13 @@ jobs:
   tag-bump-commit:
     uses: ./.github/workflows/tag-bump-commit.yml
     needs: filter-vtags
-    # Run only when NOT a vtag
-    if: needs.filter-vtags.outputs.is_vtag != 'true'
+    if: fromJSON(needs.filter-vtags.outputs.is_vtag || 'false') == false
 
   buildpush:
     name: buildpush
     runs-on: ubuntu-latest
     needs: tag-bump-commit
-    # Run only when tag-bump-commit did NOT create a tag
-    if: always() && needs.tag-bump-commit.outputs.did_tag != 'true'
+    if: always() && fromJSON(needs.tag-bump-commit.outputs.did_tag || 'false') == false
     steps:
       - uses: actions/checkout@main
         with:
@@ -49,20 +148,19 @@ jobs:
           sudo npm install -g pxt
           npm install
 
-      # - name: pxt ci (without publish capability)
-      #   run: pxt ci
-      #   env:
-      #     CHROME_BIN: chromium-browser
-      #     DISPLAY: :99.0
-      #     CI: true
-      # unsupported
+      - name: pxt ci (without publish capability)
+        run: |
+          pxt ci
+        env:
+          CHROME_BIN: chromium-browser
+          DISPLAY: :99.0
+          CI: true
 
   buildvtag:
     name: buildvtag
     runs-on: ubuntu-latest
     needs: tag-bump-commit
-    # Run only when tag-bump-commit DID create a tag
-    if: always() && needs.tag-bump-commit.outputs.did_tag == 'true'
+    if: always() && fromJSON(needs.tag-bump-commit.outputs.did_tag || 'false') == true
     steps:
       - uses: actions/checkout@main
         with:
@@ -83,16 +181,9 @@ jobs:
           sudo npm install -g pxt
           npm install
 
-      - name: Checkout pxt-arcade-sim
-        uses: actions/checkout@v5
-        with:
-          repository: microsoft/pxt-arcade-sim
-          ref: v0.12.3
-          ssh-key: ${{ secrets.SIM_DEPLOY_KEY }}
-          path: node_modules/pxt-arcade-sim
-
       - name: pxt ci (with publish capability)
-        run: pxt ci --publish
+        run: |
+          pxt ci --publish
         env:
           NPM_PUBLISH: true
           CHROME_BIN: chromium-browser