Update and rename docs/fileBytes.md to docs/developers/fileBytes.md#96
Update and rename docs/fileBytes.md to docs/developers/fileBytes.md#96DeveloperTryingToCodeLikeOtherOfThem wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the header in the fileBytes documentation and moves the file to a subdirectory. The review feedback highlights that this move breaks the documentation index and hardcoded links, necessitating updates to the indexing script and existing references.
| @@ -1,4 +1,4 @@ | |||
| ## How Many Bytes Does a File Need? | |||
| ## Bytes for a File | |||
There was a problem hiding this comment.
Moving this file to the developers/ subdirectory breaks the documentation index. The docs-index.html file contains a hardcoded link to the old path (line 21), and scripts/generate-docs-index.js only performs a shallow scan of the docs/ directory, which will cause this file to be omitted from future index generations. Please update the indexing logic to handle nested directories and update the hardcoded links.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 340e029744
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,4 @@ | |||
| ## How Many Bytes Does a File Need? | |||
| ## Bytes for a File | |||
There was a problem hiding this comment.
Update publish manifest when moving this doc
Relocating this file removes docs/fileBytes.md, but the npm files whitelist in package.json still points to the old path (docs/fileBytes.md at line 81), so the new docs/developers/fileBytes.md is not included in npm pack/publish. That makes the moved doc disappear for package consumers and can break tooling that expects it to ship; update manifest references to the new location as part of this move.
Useful? React with 👍 / 👎.
No description provided.