refactor(dvc)!: use DvcClientProcessor for client DVCs#1377
Draft
uchouT (uchouT) wants to merge 3 commits into
Draft
refactor(dvc)!: use DvcClientProcessor for client DVCs#1377uchouT (uchouT) wants to merge 3 commits into
uchouT (uchouT) wants to merge 3 commits into
Conversation
uchouT (uchouT)
force-pushed
the
refactor/dvc
branch
from
409c0be to
11fe23a
Compare
uchouT (uchouT)
changed the title
uchouT (uchouT)
force-pushed
the
refactor/dvc
branch
3 times, most recently
from
2e610e0 to
a79180c
Compare
Add mutable dynamic channel lookup APIs for drdynvc server. Signed-off-by: uchouT <i@uchout.moe>
Rework DVC channel access APIs around typed processor handles. - Make client dynamic channel wrapper `DynamicVirtualChannel` types private. - Use typed dynamic channel ref/mut accessors carrying both channel id and processor borrow. - Align client DVC listener/registration APIs on `DvcClientProcessor`. BREAKING CHANGE: UrbdrcClient no longer expose `DynamicVirtualChannel`. client DVC listener/registration APIs now return/accept `DvcClientProcessor`. Signed-off-by: uchouT <i@uchout.moe>
Signed-off-by: uchouT <i@uchout.moe>
uchouT (uchouT)
force-pushed
the
refactor/dvc
branch
from
a79180c to
78a24d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently blocked by #1368.
Rework DVC channel access APIs around typed processor handles.
DynamicVirtualChanneltypesprivate.
and processor borrow.
DvcClientProcessor.BREAKING CHANGE: UrbdrcClient no longer expose
DynamicVirtualChannel.client DVC listener/registration APIs now return/accept
DvcClientProcessor.