Credential hand-over to per-user server sessions#1413
Open
Piclaw (piclaw-bot) wants to merge 5 commits into
Open
Credential hand-over to per-user server sessions#1413Piclaw (piclaw-bot) wants to merge 5 commits into
Piclaw (piclaw-bot) wants to merge 5 commits into
Conversation
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces and consolidates #1409, #1410, #1411, and #1412 into a single branch from
rcarmo:wrdp.The split PR heads use
wrdp/*branch names, but the fork now uses the canonicalwrdpbranch. Because Git cannot keep bothrefs/heads/wrdpandrefs/heads/wrdp/*at the same time, this PR carries the updated commits and review fixes together.Why
wrdpfollows thexrdp-sesmanmulti-user architecture model, so it needs a way to hand authenticated credentials from the protocol handshake into the per-user session binder.Changes
ironrdp-server.Credentialsshape used by ClientInfo.Copilot review follow-up
This includes fixes for the Copilot comments from the superseded PRs:
Validation
cargo check -p ironrdp-server -p ironrdp-acceptorgit diff --check