Some preliminary refactoring for #670#782
Merged
Merged
Conversation
"session" has a fixed set of supported codecs with associated IDs. "connector" must expose the set of codecs during capabilities exchange. It currently uses hard-codes codec IDs in different places. Move the BitmapCodecs set to ironrdp-pdu. Shared code will be used by the server, so this is a suitable common place. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
No need to special-case codec_properties_len == 0, defer to the decoding of the properties instead. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Marc-Andre Lureau (elmarco)
changed the title
Contributor
Author
Benoît Cortier (CBenoit)
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #670