feat(dvc): make dvc named pipe proxy cross-platform

[Vladyslav Nikonov (pacmancoder)]

Changes

• Make dvc named pipe proxy cross-platform (Unix implementation via tokio::net::unix::UnixStream)
• Removed unsafe code for Windows implementation, switched to tokio::net::windows::named_pipe

Testing

This feature can be used in the same way as on Windows, however instead of GUI test app there is new basic CLI app

[github-actions]

Coverage Report 🤖 ⚙️

Past:
Total lines: 28665
Covered lines: 17562 (61.27%)

New:
Total lines: 28665
Covered lines: 17562 (61.27%)

Diff: +0.00%

[this comment will be updated automatically]

[Benoît Cortier (CBenoit)]

question: Leftover?

[Benoît Cortier (CBenoit)]

note: We loose the sync-friendly non-tokio-specific interface you made efforts to keep, but at the same time the tradeoff seems worth it.

question: Just to be on the safe side, can you double check you really enabled only the minimal amount of features?

[Vladyslav Nikonov (pacmancoder)]

Yep, feature set is minimal

[Benoît Cortier (CBenoit)]

LGTM!

I appreciate that the API surface is very small. I see you were careful about making tokio an internal, implementation detail.

However, the downside is that we end up using two runtimes, and it’s overall a bit heavier. Maybe you could expose an async function to "ignite" the worker manually into the tokio thread pool of the consumer, and use some opaque handle that can be re-injected into DvcNamedPipeProxy, and re-used in start.

Feel free to modify and merge yourself!

[Vladyslav Nikonov (pacmancoder)]

However, the downside is that we end up using two runtimes, and it’s overall a bit heavier. Maybe you could expose an async function to "ignite" the worker manually into the tokio thread pool of the consumer, and use some opaque handle that can be re-injected into DvcNamedPipeProxy, and re-used in start.

Decided to keep it as-is for now, as the current dvc proxy uses current_thread runtime with a single thread spawned; Should not be a problem, as we only need to proxy a single channel.