Skip to content

Commit 114a8bb

Browse files
committed
more accurate comments regarding from where executables are picked from (#3703)
1 parent f515786 commit 114a8bb

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/UniGetUI.PackageEngine.PackageManagerClasses/Manager/PackageManager.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,17 +153,17 @@ public Tuple<bool, string> GetExecutableFile()
153153
}
154154

155155
// While technically executables that are not in the path should work,
156-
// since detection of executables will be performed in the path only, it is more consistent
157-
// to throw an error when a non-path executable is used. Furthermore, doing this we can filter out
158-
// any invalid paths or files
156+
// since detection of executables will be performed on the found paths, it is more consistent
157+
// to throw an error when a non-found executable is used. Furthermore, doing this we can filter out
158+
// any invalid paths or files.
159159
if (candidates.Select(x => x.ToLower()).Contains(exeSelection.ToLower()))
160160
{
161161
return new(true, exeSelection);
162162
}
163163
else
164164
{
165-
Logger.Error($"The selected executable path {exeSelection} for manager {Name} was not found in path " +
166-
$"(executables found in path are [{string.Join(',', candidates)}]), the default will be used...");
165+
Logger.Error($"The selected executable path {exeSelection} for manager {Name} was not found among the candidates " +
166+
$"(executables found are [{string.Join(',', candidates)}]), the default will be used...");
167167
return new(true, candidates[0]);
168168
}
169169

src/UniGetUI/Pages/SettingsPages/ManagersPages/PackageManager.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
ContentAlignment="Vertical"
6161
CornerRadius="0,0,0,0">
6262
<controls:SettingsCard.Header>
63-
<TextBlock Text="Select the executable to be used. Only executables found in path will be shown" />
63+
<TextBlock Text="Select the executable to be used. The following list shows the executables found by UniGetUI" />
6464
</controls:SettingsCard.Header>
6565
<controls:SettingsCard.Content>
6666
<Grid HorizontalAlignment="Left" RowSpacing="4" ColumnSpacing="4">

0 commit comments

Comments
 (0)