Move all InstallationOptions instances to SerializableInstallationOptions

Author: marticliment

src/UniGetUI.Core.LanguageEngine/LanguageData.cs

@@ -5,6 +5,7 @@
 using UniGetUI.Core.Data;
 using UniGetUI.Core.Logging;
 using UniGetUI.PackageEngine.Enums;
+using Architecture = UniGetUI.PackageEngine.Enums.Architecture;
 
 namespace UniGetUI.Core.Language
 {
@@ -151,41 +152,41 @@ private static Person[] LoadLanguageTranslatorList()
 
     public static class CommonTranslations
     {
-        public static readonly Dictionary<Architecture, string> ArchNames = new()
+        public static readonly Dictionary<string, string> ArchNames = new()
         {
             { Architecture.X64, "x64" },
             { Architecture.X86, "x86" },
             { Architecture.Arm64, "arm64" },
             { Architecture.Arm, "arm32" },
         };
 
-        public static readonly Dictionary<string, Architecture> InvertedArchNames = new()
+        public static readonly Dictionary<string, string> InvertedArchNames = new()
         {
             { "x64", Architecture.X64 },
             { "x86", Architecture.X86 },
             { "arm64", Architecture.Arm64 },
             { "arm32", Architecture.Arm },
         };
 
-        public static readonly Dictionary<PackageScope, string> ScopeNames = new()
+        public static readonly Dictionary<string, string> ScopeNames = new()
         {
             { PackageScope.Global, "Machine | Global" },
             { PackageScope.Local, "User | Local" },
         };
 
-        public static readonly Dictionary<string, PackageScope> InvertedScopeNames = new()
+        public static readonly Dictionary<string, string> InvertedScopeNames = new()
         {
             { "Machine | Global", PackageScope.Global },
             { "User | Local", PackageScope.Local },
         };
 
-        public static readonly Dictionary<PackageScope, string> ScopeNames_NonLang = new()
+        public static readonly Dictionary<string, string> ScopeNames_NonLang = new()
         {
             { PackageScope.Global, "machine" },
             { PackageScope.Local, "user" },
         };
 
-        public static readonly Dictionary<string, PackageScope> InvertedScopeNames_NonLang = new()
+        public static readonly Dictionary<string, string> InvertedScopeNames_NonLang = new()
         {
             { "machine", PackageScope.Global },
             { "user", PackageScope.Local },

src/UniGetUI.PAckageEngine.Interfaces/IInstallationOptions.cs

@@ -149,7 +149,7 @@ public interface IPackage : INotifyPropertyChanged, IEquatable<IPackage>
         /// <returns>False if the update is a major update or the update doesn't exist, true if it's a minor update</returns>
         public bool IsUpdateMinor();
 
-        public SerializablePackage AsSerializable();
+        public Task<SerializablePackage> AsSerializableAsync();
 
         public SerializableIncompatiblePackage AsSerializable_Incompatible();
     }

src/UniGetUI.PAckageEngine.Interfaces/IPackage.cs

@@ -1,4 +1,5 @@
 using UniGetUI.PackageEngine.Enums;
+using UniGetUI.PackageEngine.Serializable;
 
 namespace UniGetUI.PackageEngine.Interfaces.ManagerProviders
 {
@@ -12,11 +13,9 @@ public interface IPackageOperationHelper
         /// that the requested operation is performed over the given package, with its corresponding
         /// installation options.
         /// </summary>
-        public IReadOnlyList<string> GetParameters(
-            IPackage package,
-            IInstallationOptions options,
-            OperationType operation
-        );
+        public IReadOnlyList<string> GetParameters(IPackage package,
+            SerializableInstallationOptions options,
+            OperationType operation);
 
         /// <summary>
         /// Returns the veredict of the given package operation, given the package, the operation type,

src/UniGetUI.PAckageEngine.Interfaces/ManagerHelpers/IPackageOperationHelper.cs

@@ -3,12 +3,20 @@ namespace UniGetUI.PackageEngine.Enums
     /// <summary>
     /// Represents the installation scope of a package
     /// </summary>
-    public enum PackageScope
+    public static class PackageScope
     {
-        Global = 1,
-        Machine = 1,
-        Local = 0,
-        User = 0,
+        public const string Global = "machine";
+        public const string Machine = "machine";
+        public const string Local = "user";
+        public const string User = "user";
+    }
+
+    public static class Architecture
+    {
+        public const string X86 = "x86";
+        public const string X64 = "x64";
+        public const string Arm = "arm32";
+        public const string Arm64 = "arm64";
     }
 
     public enum DeserializedPackageStatus

src/UniGetUI.PackageEngine.Enums/Enums.cs

@@ -28,7 +28,7 @@ public struct ManagerCapabilities
         public bool CanDownloadInstaller = false;
         public bool SupportsCustomVersions = false;
         public bool SupportsCustomArchitectures = false;
-        public Architecture[] SupportedCustomArchitectures = [];
+        public string[] SupportedCustomArchitectures = [];
         public bool SupportsCustomScopes = false;
         public bool SupportsPreRelease = false;
         public bool SupportsCustomLocations = false;

src/UniGetUI.PackageEngine.Enums/ManagerCapabilities.cs

@@ -3,12 +3,12 @@
 namespace UniGetUI.PackageEngine.Structs;
 public struct OverridenInstallationOptions
 {
-    public PackageScope? Scope;
+    public string? Scope;
     public bool? RunAsAdministrator;
     public bool PowerShell_DoNotSetScopeParameter = false;
     public bool? WinGet_SpecifyVersion = null;
 
-    public OverridenInstallationOptions(PackageScope? scope = null, bool? runAsAdministrator = null)
+    public OverridenInstallationOptions(string? scope = null, bool? runAsAdministrator = null)
     {
         Scope = scope;
         RunAsAdministrator = runAsAdministrator;

src/UniGetUI.PackageEngine.Enums/OverridenInstallationOptions.cs

@@ -1,12 +1,14 @@
 using UniGetUI.PackageEngine.Classes.Manager.BaseProviders;
 using UniGetUI.PackageEngine.Enums;
 using UniGetUI.PackageEngine.Interfaces;
+using UniGetUI.PackageEngine.Serializable;
 
 namespace UniGetUI.PackageEngine.Managers.CargoManager;
 
 internal sealed class CargoPkgOperationHelper(Cargo cargo) : BasePkgOperationHelper(cargo)
 {
-    protected override IReadOnlyList<string> _getOperationParameters(IPackage package, IInstallationOptions options, OperationType operation)
+    protected override IReadOnlyList<string> _getOperationParameters(IPackage package,
+        SerializableInstallationOptions options, OperationType operation)
     {
         var version = options.Version == string.Empty ? package.VersionString : options.Version;
         List<string> parameters = operation switch

src/UniGetUI.PackageEngine.Managers.Cargo/Helpers/CargoPkgOperationHelper.cs

@@ -13,6 +13,7 @@
 using UniGetUI.PackageEngine.Managers.Choco;
 using UniGetUI.PackageEngine.Managers.PowerShellManager;
 using UniGetUI.PackageEngine.PackageClasses;
+using Architecture = UniGetUI.PackageEngine.Enums.Architecture;
 
 namespace UniGetUI.PackageEngine.Managers.ChocolateyManager
 {

src/UniGetUI.PackageEngine.Managers.Chocolatey/Chocolatey.cs

@@ -2,15 +2,16 @@
 using UniGetUI.PackageEngine.Classes.Manager.BaseProviders;
 using UniGetUI.PackageEngine.Enums;
 using UniGetUI.PackageEngine.Interfaces;
+using UniGetUI.PackageEngine.Serializable;
+using Architecture = UniGetUI.PackageEngine.Enums.Architecture;
 
 namespace UniGetUI.PackageEngine.Managers.ChocolateyManager;
 internal sealed class ChocolateyPkgOperationHelper : BasePkgOperationHelper
 {
     public ChocolateyPkgOperationHelper(Chocolatey manager) : base(manager) { }
 
-    protected override IReadOnlyList<string> _getOperationParameters(
-        IPackage package,
-        IInstallationOptions options,
+    protected override IReadOnlyList<string> _getOperationParameters(IPackage package,
+        SerializableInstallationOptions options,
         OperationType operation)
     {
         List<string> parameters = [operation switch {