Remove now redundant setting to run all packages for a package manager with administrator rights

Author: marticliment

src/UniGetUI.PackageEngine.Operations/PackageOperations.cs

@@ -53,11 +53,7 @@ public PackageOperation(
         }
 
         private bool RequiresAdminRights()
-        {
-            return Package.OverridenOptions.RunAsAdministrator is true
-                    || Options.RunAsAdministrator
-                    || (Settings.GetDictionaryItem<string, bool>("AlwaysElevate", Package.Manager.Name) && Package.OverridenOptions.RunAsAdministrator != false);
-        }
+            => Package.OverridenOptions.RunAsAdministrator is true || Options.RunAsAdministrator;
 
         protected override void ApplyRetryAction(string retryMode)
         {

src/UniGetUI/MainWindow.xaml.cs

@@ -258,20 +258,6 @@ private static void TransferOldSettingsFormats()
 
                 Settings.Set("TransferredOldSettings", true);
             }
-
-            if (!Settings.Get("TransferredOldSettingsv2"))
-            {
-                foreach (IPackageManager Manager in PEInterface.Managers)
-                {
-                    string SettingName = "AlwaysElevate" + Manager.Name;
-                    if (Settings.Get(SettingName))
-                    {
-                        Settings.SetDictionaryItem("AlwaysElevate", Manager.Name, true);
-                        Settings.Set(SettingName, false);
-                    }
-                }
-                Settings.Set("TransferredOldSettingsv2", true);
-            }
         }
 
         public void HandleNotificationActivation(AppNotificationActivatedEventArgs args)

src/UniGetUI/Pages/SettingsPages/ManagersPages/PackageManager.xaml.cs

@@ -76,15 +76,6 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
             SettingsTitle.Text = CoreTools.Translate("{0} settings", Manager.DisplayName);
             StatusTitle.Text = CoreTools.Translate("{0} status", Manager.DisplayName);
 
-            var AlwaysElevateManagerOP = new CheckboxCard_Dict()
-            {
-                Text = CoreTools.Translate("Always run {pm} operations with administrator rights").Replace("{pm}", Manager.DisplayName),
-                DictionaryName = "AlwaysElevate",
-                SettingName = Manager.Name,
-                CornerRadius = new CornerRadius(8,8,0,0),
-                BorderThickness = new Thickness(1,1,1,0),
-            };
-
             var DisableNotifsCard = new CheckboxCard_Dict()
             {
                 Text = CoreTools.Translate("Ignore packages from {pm} when showing a notification about updates").Replace("{pm}", Manager.DisplayName),
@@ -119,7 +110,6 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
             {
                 DisableNotifsCard.CornerRadius = new CornerRadius(0);
                 DisableNotifsCard.BorderThickness = new Thickness(1, 1, 1, 0);
-                ExtraControls.Children.Add(AlwaysElevateManagerOP);
                 ExtraControls.Children.Add(DisableNotifsCard);
 
                 ButtonCard WinGet_ResetWindowsIPackageManager = new()
@@ -185,7 +175,6 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
             {
                 DisableNotifsCard.CornerRadius = new CornerRadius(0);
                 DisableNotifsCard.BorderThickness = new Thickness(1, 1, 1, 0);
-                ExtraControls.Children.Add(AlwaysElevateManagerOP);
                 ExtraControls.Children.Add(DisableNotifsCard);
 
                 ButtonCard Scoop_Install = new()
@@ -248,7 +237,6 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
             {
                 DisableNotifsCard.CornerRadius = new CornerRadius(0);
                 DisableNotifsCard.BorderThickness = new Thickness(1, 1, 1, 0);
-                ExtraControls.Children.Add(AlwaysElevateManagerOP);
                 ExtraControls.Children.Add(DisableNotifsCard);
 
                 CheckboxCard Chocolatey_SystemChoco = new()
@@ -267,7 +255,6 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
             {
                 DisableNotifsCard.CornerRadius = new CornerRadius(0);
                 DisableNotifsCard.BorderThickness = new Thickness(1, 1, 1, 0);
-                ExtraControls.Children.Add(AlwaysElevateManagerOP);
                 ExtraControls.Children.Add(DisableNotifsCard);
 
                 Settings.SetValue("DefaultVcpkgTriplet", Vcpkg.GetDefaultTriplet());
@@ -344,7 +331,6 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
             {
                 DisableNotifsCard.CornerRadius = new CornerRadius(0, 0, 8, 8);
                 DisableNotifsCard.BorderThickness = new Thickness(1, 1, 1, 1);
-                ExtraControls.Children.Add(AlwaysElevateManagerOP);
                 ExtraControls.Children.Add(DisableNotifsCard);
             }