Add the option for UniGetUI to kill a process name before an operation with a package is performed

marticliment · marticliment · commit 4923dde03bad · 2025-06-17T15:43:13.000+02:00
diff --git a/src/UniGetUI.PackageEngine.Operations/AbstractOperation.cs b/src/UniGetUI.PackageEngine.Operations/AbstractOperation.cs
@@ -23,7 +23,7 @@ public abstract partial class AbstractOperation : IDisposable
     public bool Started { get; private set; }
     protected bool QUEUE_ENABLED;
     protected bool FORCE_HOLD_QUEUE;
-    private bool IsInnerOperation = false;
+    private bool IsInnerOperation;
 
     private readonly List<(string, LineType)> LogList = [];
     private OperationStatus _status = OperationStatus.InQueue;
@@ -38,7 +38,6 @@ public void ApplyCapabilities(bool admin, bool interactive, bool skiphash, strin
         BadgesChanged?.Invoke(this, new BadgeCollection(admin, interactive, skiphash, scope));
     }
 
-    // private readonly AbstractOperation? requirement;
     private readonly IReadOnlyList<InnerOperation> PreOperations = [];
     private readonly IReadOnlyList<InnerOperation> PostOperations = [];
 
diff --git a/src/UniGetUI.PackageEngine.Operations/AbstractProcessOperation.cs b/src/UniGetUI.PackageEngine.Operations/AbstractProcessOperation.cs
diff --git a/src/UniGetUI.PackageEngine.Operations/KillProcessOperation.cs b/src/UniGetUI.PackageEngine.Operations/KillProcessOperation.cs
@@ -0,0 +1,57 @@
+
+using System.Diagnostics;
+using UniGetUI.Core.Tools;
+using UniGetUI.PackageEngine.Enums;
+
+namespace UniGetUI.PackageOperations;
+
+public class KillProcessOperation: AbstractOperation
+{
+    private string ProcessName;
+    public KillProcessOperation(string procName) : base(false)
+    {
+        ProcessName = CoreTools.MakeValidFileName(procName);
+        Metadata.Status = $"Closing process(es) {procName}";
+        Metadata.Title = $"Closing process(es) {procName}";
+        Metadata.OperationInformation = " ";
+        Metadata.SuccessTitle = $"Done!";
+        Metadata.SuccessMessage = $"Done!";
+        Metadata.FailureTitle = $"Failed to close process";
+        Metadata.FailureMessage = $"The process(es) {procName} could not be closed";
+    }
+
+    protected override void ApplyRetryAction(string retryMode)
+    {
+    }
+
+    protected override async Task<OperationVeredict> PerformOperation()
+    {
+        try
+        {
+            Line($"Attempting to close all processes with name {ProcessName}...", LineType.Information);
+            var procs = Process.GetProcessesByName(ProcessName.Replace(".exe", ""));
+            foreach (var proc in procs)
+            {
+                if(proc.HasExited) continue;
+                Line($"Attempting to close process {ProcessName} with pid={proc.Id}...", LineType.VerboseDetails);
+                proc.CloseMainWindow();
+                await Task.WhenAny(proc.WaitForExitAsync(), Task.Delay(1000));
+                if (!proc.HasExited)
+                {
+                    Line($"Timeout for process {ProcessName}, attempting to kill...", LineType.Information);
+                    proc.Kill();
+                }
+            }
+
+            return OperationVeredict.Success;
+        }
+        catch (Exception ex)
+        {
+            Line(ex.ToString(), LineType.Error);
+            return OperationVeredict.Failure;
+        }
+    }
+
+    public override Task<Uri> GetOperationIcon()
+        => Task.FromResult(new Uri("about:blank"));
+}
diff --git a/src/UniGetUI.PackageEngine.Operations/PackageOperations.cs b/src/UniGetUI.PackageEngine.Operations/PackageOperations.cs
@@ -132,10 +132,13 @@ public override Task<Uri> GetOperationIcon()
         private static IReadOnlyList<InnerOperation> _getPreInstallOps(InstallOptions opts, AbstractOperation? preReq = null)
         {
             List<InnerOperation> l = new();
+            if(preReq is not null) l.Add(new(preReq, true));
 
-            // Things Things Things
+            foreach (var process in opts.KillBeforeOperation)
+                l.Add(new InnerOperation(
+                    new KillProcessOperation(process),
+                    mustSucceed: false));
 
-            if(preReq is not null) l.Add(new(preReq, true));
             return l;
         }
 
diff --git a/src/UniGetUI.PackageEngine.Serializable/InstallOptions.cs b/src/UniGetUI.PackageEngine.Serializable/InstallOptions.cs
@@ -19,6 +19,8 @@ public class InstallOptions: SerializableComponent<InstallOptions>
         public bool SkipMinorUpdates { get; set; }
         public bool OverridesNextLevelOpts { get; set; }
         public bool RemoveDataOnUninstall { get; set; }
+        public List<string> KillBeforeOperation { get; set; } = [];
+
 
         public override InstallOptions Copy()
         {
@@ -27,9 +29,9 @@ public override InstallOptions Copy()
                 SkipHashCheck = SkipHashCheck,
                 Architecture = Architecture,
                 CustomInstallLocation = CustomInstallLocation,
-                CustomParameters_Install = CustomParameters_Install,
-                CustomParameters_Update = CustomParameters_Update,
-                CustomParameters_Uninstall = CustomParameters_Uninstall,
+                CustomParameters_Install = CustomParameters_Install.ToList(),
+                CustomParameters_Update = CustomParameters_Update.ToList(),
+                CustomParameters_Uninstall = CustomParameters_Uninstall.ToList(),
                 InstallationScope = InstallationScope,
                 InteractiveInstallation = InteractiveInstallation,
                 PreRelease = PreRelease,
@@ -38,6 +40,7 @@ public override InstallOptions Copy()
                 SkipMinorUpdates = SkipMinorUpdates,
                 OverridesNextLevelOpts = OverridesNextLevelOpts,
                 RemoveDataOnUninstall = RemoveDataOnUninstall,
+                KillBeforeOperation = KillBeforeOperation.ToList(),
             };
         }
 
@@ -65,6 +68,7 @@ this.CustomParameters_Uninstall.Count is 0 &&
                 this.CustomParameters_Uninstall = ReadArrayFromJson(data, "CustomParameters");
             }
 
+            this.KillBeforeOperation = ReadArrayFromJson(data, nameof(KillBeforeOperation));
             this.PreRelease = data[nameof(PreRelease)]?.GetVal<bool>() ?? false;
             this.CustomInstallLocation = data[nameof(CustomInstallLocation)]?.GetVal<string>() ?? "";
             this.Version = data[nameof(Version)]?.GetVal<string>() ?? "";
@@ -98,6 +102,7 @@ SkipMinorUpdates is not false ||
                    CustomParameters_Install.Where(x => x != "").Any() ||
                    CustomParameters_Update.Where(x => x != "").Any() ||
                    CustomParameters_Uninstall.Where(x => x != "").Any() ||
+                   KillBeforeOperation.Where(x => x != "").Any() ||
                    CustomInstallLocation.Any() ||
                    RemoveDataOnUninstall is not false ||
                    Version.Any();
@@ -115,8 +120,8 @@ public InstallOptions(JsonNode data) : base(data)
 
         public override string ToString()
         {
-            string customparams = CustomParameters_Install.Any() ? string.Join(",", CustomParameters_Install) : "[]";
-            customparams += CustomParameters_Update.Any() ? string.Join(",", CustomParameters_Update) : "[]";
+            string customparams = CustomParameters_Install.Any() ? string.Join(",", CustomParameters_Install) : "[],";
+            customparams += CustomParameters_Update.Any() ? string.Join(",", CustomParameters_Update) : "[],";
             customparams += CustomParameters_Uninstall.Any() ? string.Join(",", CustomParameters_Uninstall) : "[]";
             return $"<InstallOptions: SkipHashCheck={SkipHashCheck};" +
                    $"InteractiveInstallation={InteractiveInstallation};" +
@@ -127,6 +132,7 @@ public override string ToString()
                    $"InstallationScope={CustomInstallLocation};" +
                    $"CustomParameters={customparams};" +
                    $"RemoveDataOnUninstall={RemoveDataOnUninstall};" +
+                   $"KillBeforeOperation={KillBeforeOperation};" +
                    $"PreRelease={PreRelease}>";
         }
     }
diff --git a/src/UniGetUI/Controls/MenuForPackage.cs b/src/UniGetUI/Controls/MenuForPackage.cs
@@ -76,6 +76,7 @@ public partial class BetterTabViewItem : TabViewItem
         public BetterTabViewItem()
         {
             IsClosable = false;
+            CanDrag = false;
         }
 
         public void LoadText()
diff --git a/src/UniGetUI/Pages/DialogPages/InstallOptions_Package.xaml b/src/UniGetUI/Pages/DialogPages/InstallOptions_Package.xaml
@@ -11,6 +11,16 @@
     xmlns:widgets="using:UniGetUI.Interface.Widgets"
     MaxWidth="700"
     mc:Ignorable="d">
+    <Page.Resources>
+        <DataTemplate x:Key="ProcessTemplate" x:DataType="local:IOP_Proc">
+            <StackPanel Orientation="Horizontal">
+                <Viewbox Width="16">
+                    <FontIcon Glyph="&#xECAA;" />
+                </Viewbox>
+                <TextBlock Padding="8,0,0,0" Text="{x:Bind Name}" />
+            </StackPanel>
+        </DataTemplate>
+    </Page.Resources>
     <Grid>
         <Grid.RowDefinitions>
             <RowDefinition Height="*" />
@@ -131,6 +141,7 @@
                                     HorizontalAlignment="Stretch"
                                     Background="{ThemeResource SystemChromeAltHighColor}"
                                     IsAddTabButtonVisible="False"
+                                    CanReorderTabs="False"
                                     TabWidthMode="SizeToContent">
                                     <widgets:BetterTabViewItem
                                         IconName="Settings"
@@ -210,6 +221,24 @@
                                                 <widgets:TranslatedTextBlock Text="Skip minor updates for this package" />
                                             </CheckBox>
                                         </controls:WrapPanel>
+                                        <controls:TokenizingTextBox
+                                            x:Name="KillProcessesBox"
+                                            MaxWidth="620"
+                                            HorizontalAlignment="Left"
+                                            ItemsSource="{x:Bind ProcessesToKill, Mode=TwoWay}"
+                                            Loaded="KillProcessesBox_Loaded"
+                                            PlaceholderText="process1.exe,process2.exe"
+                                            SuggestedItemTemplate="{StaticResource ProcessTemplate}"
+                                            SuggestedItemsSource="{x:Bind SuggestedProcesses, Mode=OneWay}"
+                                            TextChanged="KillProcessesBox_TextChanged"
+                                            TextMemberPath="Text"
+                                            TokenDelimiter=","
+                                            TokenItemAdding="KillProcessesBox_TokenItemAdding"
+                                            TokenItemTemplate="{StaticResource ProcessTemplate}">
+                                            <controls:TokenizingTextBox.Header>
+                                                <widgets:TranslatedTextBlock Text="Processes to close before this package is installed, updated or uninstalled:" />
+                                            </controls:TokenizingTextBox.Header>
+                                        </controls:TokenizingTextBox>
                                     </StackPanel>
                                 </controls:Case>
 
diff --git a/src/UniGetUI/Pages/DialogPages/InstallOptions_Package.xaml.cs b/src/UniGetUI/Pages/DialogPages/InstallOptions_Package.xaml.cs
@@ -1,5 +1,9 @@
+using System.Collections.ObjectModel;
+using System.ComponentModel;
 using System.Data;
+using System.Diagnostics;
 using System.Runtime.InteropServices;
+using CommunityToolkit.WinUI.Controls;
 using Microsoft.Extensions.Options;
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
@@ -13,6 +17,7 @@
 using UniGetUI.PackageEngine.Serializable;
 using UniGetUI.Pages.SettingsPages.GeneralPages;
 using Windows.ApplicationModel.Activation;
+using Windows.Services.Maps;
 using Architecture = UniGetUI.PackageEngine.Enums.Architecture;
 
 // To learn more about WinUI, the WinUI project structure,
@@ -32,6 +37,10 @@ public sealed partial class InstallOptionsPage : Page
         private readonly string packageInstallLocation;
         private bool _uiLoaded;
 
+        public ObservableCollection<IOP_Proc> ProcessesToKill = new();
+        private readonly ObservableCollection<IOP_Proc> _runningProcesses = new();
+        public ObservableCollection<IOP_Proc> SuggestedProcesses = new();
+
         public InstallOptionsPage(IPackage package, InstallOptions options) : this(package, OperationType.None, options) { }
         public InstallOptionsPage(IPackage package, OperationType operation, InstallOptions options)
         {
@@ -82,6 +91,7 @@ async Task LoadImage()
             _ = LoadImage();
             DialogTitle.Text = CoreTools.Translate("{0} installation options", package.Name);
             PlaceholderText.Text = CoreTools.Translate("{0} Install options are currently locked because {0} follows the default install options.", package.Name);
+            KillProcessesBox.PlaceholderText = CoreTools.Translate("Write here the process names, separed by commas (,)");
 
             packageInstallLocation = Package.Manager.DetailsHelper.GetInstallLocation(package) ?? CoreTools.Translate("Unset or unknown");
 
@@ -154,20 +164,35 @@ async Task LoadImage()
                 }
             }
 
+            foreach(var p in Options.KillBeforeOperation)
+            {
+                ProcessesToKill.Add(new(p));
+            }
 
             if (Options.CustomInstallLocation == "") CustomInstallLocation.Text = packageInstallLocation;
             else CustomInstallLocation.Text = Options.CustomInstallLocation;
 
-
             CustomParameters1.Text = string.Join(' ', Options.CustomParameters_Install);
             CustomParameters2.Text = string.Join(' ', Options.CustomParameters_Update);
             CustomParameters3.Text = string.Join(' ', Options.CustomParameters_Uninstall);
 
             _uiLoaded = true;
             EnableDisableControls(operation);
             LoadIgnoredUpdates();
+            _ = _loadProcesses();
         }
 
+        private async Task _loadProcesses()
+        {
+            var processNames = await Task.Run(() =>
+                Process.GetProcesses().Select(p => p.ProcessName).Distinct().ToList());
+
+            _runningProcesses.Clear();
+            foreach (var name in processNames)
+            {
+                if(name.Any()) _runningProcesses.Add(new(name + ".exe"));
+            }
+        }
         private void EnableDisableControls(OperationType operation)
         {
             if(FollowGlobalOptionsSwitch.IsOn)
@@ -188,13 +213,17 @@ private void EnableDisableControls(OperationType operation)
 
                 AdminCheckBox.IsEnabled = Package.Manager.Capabilities.CanRunAsAdmin;
                 InteractiveCheckBox.IsEnabled = Package.Manager.Capabilities.CanRunInteractively;
-                HashCheckbox.IsEnabled = operation != OperationType.Uninstall && Package.Manager.Capabilities.CanSkipIntegrityChecks;
-                ArchitectureComboBox.IsEnabled = operation != OperationType.Uninstall && Package.Manager.Capabilities.SupportsCustomArchitectures;
+                HashCheckbox.IsEnabled =
+                    operation is not OperationType.Uninstall
+                    && Package.Manager.Capabilities.CanSkipIntegrityChecks;
+
+                ArchitectureComboBox.IsEnabled =
+                    operation is not OperationType.Uninstall
+                    && Package.Manager.Capabilities.SupportsCustomArchitectures;
+
                 VersionComboBox.IsEnabled =
-                    (operation == OperationType.Install
-                        || operation == OperationType.None)
-                    && (Package.Manager.Capabilities.SupportsCustomVersions
-                        || Package.Manager.Capabilities.SupportsPreRelease);
+                    operation is OperationType.Install or OperationType.None
+                    && (Package.Manager.Capabilities.SupportsCustomVersions || Package.Manager.Capabilities.SupportsPreRelease);
                 ScopeCombo.IsEnabled = Package.Manager.Capabilities.SupportsCustomScopes;
                 ResetDir.IsEnabled = Package.Manager.Capabilities.SupportsCustomLocations;
                 SelectDir.IsEnabled = Package.Manager.Capabilities.SupportsCustomLocations;
@@ -269,6 +298,9 @@ public async Task<InstallOptions> GetUpdatedOptions(bool updateIgnoredUpdates =
             Options.CustomParameters_Uninstall = CustomParameters3.Text.Split(' ').ToList();
             Options.PreRelease = VersionComboBox.SelectedValue.ToString() == CoreTools.Translate("PreRelease");
 
+            Options.KillBeforeOperation.Clear();
+            foreach(var p in ProcessesToKill) Options.KillBeforeOperation.Add(p.Name);
+
             if (VersionComboBox.SelectedValue.ToString() != CoreTools.Translate("PreRelease") && VersionComboBox.SelectedValue.ToString() != CoreTools.Translate("Latest"))
             {
                 Options.Version = VersionComboBox.SelectedValue.ToString() ?? "";
@@ -363,5 +395,50 @@ private void GoToSecureSettings_Click(object sender, RoutedEventArgs e)
             Close?.Invoke(this, EventArgs.Empty);
             MainApp.Instance.MainWindow.NavigationPage.OpenSettingsPage(typeof(Administrator));
         }
+
+        private void KillProcessesBox_TokenItemAdding(TokenizingTextBox sender, TokenItemAddingEventArgs args)
+        {
+            args.Item = _runningProcesses.FirstOrDefault((item) => item.Name.Contains(args.TokenText));
+            if(args.Item is null)
+            {
+                string text = args.TokenText;
+                if (!text.EndsWith(".exe")) text += ".exe";
+                args.Item = new IOP_Proc(text);
+            }
+        }
+
+        private async void KillProcessesBox_TextChanged(AutoSuggestBox sender, AutoSuggestBoxTextChangedEventArgs args)
+        {
+            var text = KillProcessesBox.Text;
+            await Task.Delay(100);
+            if (text != KillProcessesBox.Text)
+                return;
+
+            SuggestedProcesses.Clear();
+            if (text.Trim() != "")
+            {
+                if (!text.EndsWith(".exe"))
+                    text = text.Trim() + ".exe";
+                SuggestedProcesses.Add(new(text));
+                foreach (var item in _runningProcesses.Where(x => x.Name.Contains(KillProcessesBox.Text)))
+                {
+                    SuggestedProcesses.Add(item);
+                }
+            }
+        }
+
+        private void KillProcessesBox_Loaded(object sender, RoutedEventArgs e)
+        {
+
+        }
+    }
+
+    public class IOP_Proc
+    {
+        public readonly string Name;
+        public IOP_Proc(string name)
+        {
+            Name = name;
+        }
     }
 }
diff --git a/src/UniGetUI/UniGetUI.csproj b/src/UniGetUI/UniGetUI.csproj
@@ -73,6 +73,7 @@
     <PackageReference Include="CommunityToolkit.WinUI.Controls.Segmented" Version="8.2.250402" />
     <PackageReference Include="CommunityToolkit.WinUI.Controls.SettingsControls" Version="8.2.250402" />
     <PackageReference Include="CommunityToolkit.WinUI.Controls.Sizers" Version="8.2.250402" />
+    <PackageReference Include="CommunityToolkit.WinUI.Controls.TokenizingTextBox" Version="8.2.250402" />
     <PackageReference Include="CommunityToolkit.WinUI.Converters" Version="8.2.250402" />
     <PackageReference Include="CommunityToolkit.WinUI.Media" Version="8.2.250402" />
     <PackageReference Include="H.NotifyIcon.WinUI" Version="2.3.0" />

Original file line number	Diff line number	Diff line change
`@@ -132,10 +132,13 @@ public override Task<Uri> GetOperationIcon()`
`132`	`132`	`private static IReadOnlyList<InnerOperation> _getPreInstallOps(InstallOptions opts, AbstractOperation? preReq = null)`
`133`	`133`	`{`
`134`	`134`	`List<InnerOperation> l = new();`
	`135`	`+ if(preReq is not null) l.Add(new(preReq, true));`
`135`	`136`
`136`		`- // Things Things Things`
	`137`	`+ foreach (var process in opts.KillBeforeOperation)`
	`138`	`+ l.Add(new InnerOperation(`
	`139`	`+ new KillProcessOperation(process),`
	`140`	`+ mustSucceed: false));`
`137`	`141`
`138`		`- if(preReq is not null) l.Add(new(preReq, true));`
`139`	`142`	`return l;`
`140`	`143`	`}`
`141`	`144`
Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,7 @@ public partial class BetterTabViewItem : TabViewItem`
`76`	`76`	`public BetterTabViewItem()`
`77`	`77`	`{`
`78`	`78`	`IsClosable = false;`
	`79`	`+ CanDrag = false;`
`79`	`80`	`}`
`80`	`81`
`81`	`82`	`public void LoadText()`