Move language files, prune legacy strings, and translate all languages to 100% (#4647)

Author: mamoreau-devolutions

.agents/skills/translation-diff-export/SKILL.md

@@ -30,35 +30,24 @@ Export untranslated French strings only:
 
 ```powershell
 pwsh ./.agents/skills/translation-diff-export/scripts/export-translation-diff.ps1 \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.json \
+  -NeutralJson ./src/Languages/lang_en.json \
+  -TargetJson ./src/Languages/lang_fr.json \
   -Language fr
 ```
 
 Export untranslated French strings plus English source values changed since `origin/main`:
 
 ```powershell
 pwsh ./.agents/skills/translation-diff-export/scripts/export-translation-diff.ps1 \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.json \
+  -NeutralJson ./src/Languages/lang_en.json \
+  -TargetJson ./src/Languages/lang_fr.json \
   -Language fr \
   -BaseRef origin/main
 ```
 
-Export only the active section above the legacy boundary marker:
-
-```powershell
-pwsh ./.agents/skills/translation-diff-export/scripts/export-translation-diff.ps1 \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.json \
-  -Language fr \
-  -ActiveOnly
-```
-
 Optional parameters:
 
 - `-OutputDir` (default: `generated/translation-diff-export`)
-- `-ActiveOnly` (limits `.source.json` and `.reference.json` to keys above `__LEGACY_TRANSLATION_KEYS_BELOW__`)
 - `-KeepIntermediate`
 
 Run the built-in smoke test:
@@ -101,9 +90,9 @@ After translating the patch, merge it back into the full language file with [tra
 pwsh ./.agents/skills/translation-diff-import/scripts/import-translation-diff.ps1 \
   -TranslatedPatch ./generated/translation-diff-export/lang.diff.fr.translated.json \
   -SourcePatch ./generated/translation-diff-export/lang.diff.fr.source.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.json \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -OutputJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.merged.json
+  -TargetJson ./src/Languages/lang_fr.json \
+  -NeutralJson ./src/Languages/lang_en.json \
+  -OutputJson ./src/Languages/lang_fr.merged.json
 ```
 
 Keep the `.translated.json` file sparse. If a key is not translated yet, leave it out instead of copying the English source value into the working copy.

.agents/skills/translation-diff-export/scripts/test-translation-diff.ps1

@@ -10,8 +10,8 @@ $ErrorActionPreference = 'Stop'
 . (Join-Path $PSScriptRoot 'TranslationDiff.JsonTools.ps1')
 
 $repoRoot = [System.IO.Path]::GetFullPath((Join-Path $PSScriptRoot '..\..\..\..'))
-$neutralPath = Join-Path $repoRoot 'src\UniGetUI.Core.LanguageEngine\Assets\Languages\lang_en.json'
-$targetPath = Join-Path $repoRoot ('src\UniGetUI.Core.LanguageEngine\Assets\Languages\lang_{0}.json' -f $Language)
+$neutralPath = Join-Path $repoRoot 'src\Languages\lang_en.json'
+$targetPath = Join-Path $repoRoot ('src\Languages\lang_{0}.json' -f $Language)
 $exportScript = Join-Path $PSScriptRoot 'export-translation-diff.ps1'
 $importScript = Join-Path $repoRoot '.agents\skills\translation-diff-import\scripts\import-translation-diff.ps1'
 $validateScript = Join-Path $repoRoot '.agents\skills\translation-diff-import\scripts\validate-language-file.ps1'

.agents/skills/translation-diff-import/SKILL.md

@@ -27,17 +27,17 @@ Import the translated French working copy from the export skill into the full Fr
 pwsh ./.agents/skills/translation-diff-import/scripts/import-translation-diff.ps1 \
   -TranslatedPatch ./generated/translation-diff-export/lang.diff.fr.translated.json \
   -SourcePatch ./generated/translation-diff-export/lang.diff.fr.source.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.json \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -OutputJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.merged.json
+  -TargetJson ./src/Languages/lang_fr.json \
+  -NeutralJson ./src/Languages/lang_en.json \
+  -OutputJson ./src/Languages/lang_fr.merged.json
 ```
 
 Validate the merged output:
 
 ```powershell
 pwsh ./.agents/skills/translation-diff-import/scripts/validate-language-file.ps1 \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.merged.json \
+  -NeutralJson ./src/Languages/lang_en.json \
+  -TargetJson ./src/Languages/lang_fr.merged.json \
   -PatchJson ./generated/translation-diff-export/lang.diff.fr.source.json
 ```
 

.agents/skills/translation-diff-translate/SKILL.md

@@ -32,9 +32,9 @@ pwsh ./.agents/skills/translation-diff-translate/scripts/write-translation-hando
   -SourcePatch ./generated/translation-diff-export/lang.diff.fr.source.json \
   -TranslatedPatch ./generated/translation-diff-export/lang.diff.fr.translated.json \
   -ReferencePatch ./generated/translation-diff-export/lang.diff.fr.reference.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.json \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -MergedTargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.merged.json \
+  -TargetJson ./src/Languages/lang_fr.json \
+  -NeutralJson ./src/Languages/lang_en.json \
+  -MergedTargetJson ./src/Languages/lang_fr.merged.json \
   -ValidationScript ./.agents/skills/translation-diff-import/scripts/validate-language-file.ps1 \
   -OutputPrompt ./generated/translation-diff-export/lang.diff.fr.prompt.md
 ```
@@ -58,12 +58,12 @@ Merge the sparse working copy back into the full destination-language file:
 pwsh ./.agents/skills/translation-diff-import/scripts/import-translation-diff.ps1 \
   -TranslatedPatch ./generated/translation-diff-export/lang.diff.fr.translated.json \
   -SourcePatch ./generated/translation-diff-export/lang.diff.fr.source.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.json \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -OutputJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.merged.json
+  -TargetJson ./src/Languages/lang_fr.json \
+  -NeutralJson ./src/Languages/lang_en.json \
+  -OutputJson ./src/Languages/lang_fr.merged.json
 
 pwsh ./.agents/skills/translation-diff-import/scripts/validate-language-file.ps1 \
-  -NeutralJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.merged.json \
+  -NeutralJson ./src/Languages/lang_en.json \
+  -TargetJson ./src/Languages/lang_fr.merged.json \
   -PatchJson ./generated/translation-diff-export/lang.diff.fr.source.json
 ```

.agents/skills/translation-review/SKILL.md

@@ -40,31 +40,31 @@ Generate a Markdown review report for French:
 
 ```powershell
 pwsh ./.agents/skills/translation-review/scripts/review-translation-json.ps1 \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_fr.json \
+  -TargetJson ./src/Languages/lang_fr.json \
   -Language fr
 ```
 
 Generate a report for Ukrainian and include script-detection checks:
 
 ```powershell
 pwsh ./.agents/skills/translation-review/scripts/review-translation-json.ps1 \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_ua.json \
+  -TargetJson ./src/Languages/lang_ua.json \
   -Language ua
 ```
 
 Generate a flagged-only JSON report with no cross-language table:
 
 ```powershell
 pwsh ./.agents/skills/translation-review/scripts/review-translation-json.ps1 \
-  -TargetJson ./src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_de.json \
+  -TargetJson ./src/Languages/lang_de.json \
   -Language de \
   -OutputFormat Json \
   -FlaggedOnly
 ```
 
 Optional parameters:
 
-- `-NeutralJson` — defaults to `src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json`
+- `-NeutralJson` — defaults to `src/Languages/lang_en.json`
 - `-ComparisonLanguages` — languages to include in the comparison table; defaults to other checked-in `lang_*.json` files
 - `-OutputPath` — defaults to `generated/translation-review/review.<lang>.md`
 - `-OutputFormat` — `Markdown` (default) or `Json`

.agents/skills/translation-review/scripts/review-translation-json.ps1

@@ -23,11 +23,11 @@ $repoRoot = [System.IO.Path]::GetFullPath((Join-Path $PSScriptRoot '..\..\..\..'
 . (Join-Path $repoRoot 'scripts\translation\Languages\TranslationJsonTools.ps1')
 
 function Get-TranslationReviewLanguageReferencePath {
-    return Join-Path $repoRoot 'src\UniGetUI.Core.LanguageEngine\Assets\Data\LanguagesReference.json'
+    return Join-Path $repoRoot 'src\Languages\Data\LanguagesReference.json'
 }
 
 function Get-TranslationReviewLanguagesDirectory {
-    return Join-Path $repoRoot 'src\UniGetUI.Core.LanguageEngine\Assets\Languages'
+    return Join-Path $repoRoot 'src\Languages'
 }
 
 function Get-TranslationReviewLanguageReference {

.agents/skills/translation-source-sync/SKILL.md

@@ -1,21 +1,20 @@
 ---
 name: translation-source-sync
-description: Synchronizes the UniGetUI English language file with source-code usage, identifies missing translation keys, removes unused entries, reports localization drift, and can reorder locale files to the English legacy-boundary layout. Use when the user asks to sync language files, missing translations, i18n drift, or align locale file ordering with English.
+description: Synchronizes the UniGetUI English language file with source-code usage, identifies missing translation keys, removes unused entries, reports localization drift, and can reorder locale files to match the English key ordering. Use when the user asks to sync language files, missing translations, i18n drift, or align locale file ordering with English.
 ---
 
 # translation source sync
 
-Use this skill when UniGetUI source code changed and you need to keep [src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json](src/UniGetUI.Core.LanguageEngine/Assets/Languages/lang_en.json) aligned with the strings actually used by the application, or when you need downstream locale files reordered to match the English active and legacy sections.
+Use this skill when UniGetUI source code changed and you need to keep [src/Languages/lang_en.json](src/Languages/lang_en.json) aligned with the strings actually used by the application, or when you need downstream locale files reordered to match the English key ordering.
 
-It scans supported C#, WinUI XAML, and Avalonia AXAML patterns, finds missing English keys, removes unused entries, reports translation-source warnings that still need manual cleanup, and can align locale file ordering to the English legacy-boundary layout.
+It scans supported C#, WinUI XAML, and Avalonia AXAML patterns, finds missing English keys, removes unused entries, reports translation-source warnings that still need manual cleanup, and can align locale file ordering to the English layout.
 
 ## Scope
 
 - Extract literal translation keys from supported UniGetUI source patterns.
 - Add new English keys missing from `lang_en.json`.
 - Remove English keys that are no longer used.
-- Preserve legacy English keys below the reserved boundary marker when the boundary workflow is enabled.
-- Reorder non-English locale files to match the English active and legacy key ordering.
+- Reorder non-English locale files to match the English key ordering.
 - Warn about interpolated `CoreTools.Translate($"...")` calls that are not synchronized automatically.
 - Leave downstream language propagation to the existing translation diff workflow.
 
@@ -56,7 +55,7 @@ Check whether the English file is out of sync without writing changes:
 pwsh ./.agents/skills/translation-source-sync/scripts/sync-translation-sources.ps1 -CheckOnly
 ```
 
-Reorder locale files to match the English active section and legacy-boundary tail:
+Reorder locale files to match the English key ordering:
 
 ```powershell
 pwsh ./.agents/skills/translation-source-sync/scripts/set-translation-boundary-order.ps1
@@ -79,7 +78,7 @@ pwsh ./.agents/skills/translation-source-sync/scripts/test-translation-source-sy
 1. Run translation source sync after changing any translatable source string.
 2. If `-CheckOnly` reports drift, run the full sync to rewrite `lang_en.json`.
 3. Review warnings for interpolated translation calls and convert them to stable literals or add the missing English keys manually when needed.
-4. If you are using the legacy-boundary workflow, run `pwsh ./.agents/skills/translation-source-sync/scripts/set-translation-boundary-order.ps1` to align locale ordering with English.
+4. Run `pwsh ./.agents/skills/translation-source-sync/scripts/set-translation-boundary-order.ps1` to align locale ordering with English.
 5. Run `pwsh ./scripts/translation/Verify-Translations.ps1` to confirm the language files still validate cleanly.
 6. Run `pwsh ./.agents/skills/translation-source-sync/scripts/test-translation-source-sync.ps1` if you changed the sync workflow itself.
 7. Export changed work for translators with [translation-diff-export](../translation-diff-export/SKILL.md).
@@ -88,5 +87,5 @@ pwsh ./.agents/skills/translation-source-sync/scripts/test-translation-source-sy
 
 - Existing English values are preserved for retained keys; newly added English entries default to `key == value`.
 - The sync script preserves current key order for retained entries and appends newly discovered keys deterministically.
-- The locale reorder script follows English as the canonical order and moves unmapped locale-only keys to the legacy section after the reserved boundary marker.
+- The locale reorder script follows English as the canonical order and appends unmapped locale-only keys at the end.
 - The smoke test uses a temporary synthetic repo so it does not mutate the checked-in language files.

.agents/skills/translation-status/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: translation-status
-description: Analyzes checked-in UniGetUI language files to calculate translation percentages, surface untranslated coverage data, and generate localization status reports. Boundary-aware: completion is computed from the active English section above the legacy marker.
+description: Analyzes checked-in UniGetUI language files to calculate translation percentages, surface untranslated coverage data, and generate localization status reports.
 ---
 
 # translation status
@@ -45,15 +45,13 @@ pwsh ./.agents/skills/translation-status/scripts/get-translation-status.ps1 \
 - `Code`: language code
 - `Language`: display name
 - `Completion`: computed completion percentage using English active keys only
-- `Translated`, `Missing`, `Empty`, `SourceEqual`, `Extra`: per-language entry counts for the active baseline
-- `Legacy`: count of locale keys stored below the legacy boundary marker
+- `Translated`, `Missing`, `Empty`, `SourceEqual`, `Extra`: per-language entry counts
 - `Stored` and `Delta`: stored percentage metadata and difference from the computed result
 
 ## Notes
 
 - The script treats source-equal values as untranslated for non-English languages.
-- When `lang_en.json` contains the legacy boundary marker, completion excludes legacy compatibility keys below the marker.
-- `Extra` excludes shared English legacy keys and only counts locale-only keys not present in English active or legacy sections.
+- `Extra` counts locale-only keys not present in the English file.
 - Use `-IncludeEnglish` if you want the `en` row included in the report.
 - Use `-OnlyIncomplete` to focus on languages that still need work.
 - For the full parameter surface, inspect `../../../../scripts/translation/Get-TranslationStatus.ps1`.

.github/workflows/translation-validation.yml

@@ -6,10 +6,10 @@ on:
     paths:
       - 'scripts/translation/**'
       - '.agents/skills/translation-*/scripts/**'
-      - 'src/UniGetUI.Core.LanguageEngine/Assets/Languages/**'
-      - 'src/UniGetUI.Core.LanguageEngine/Assets/Data/LanguagesReference.json'
-      - 'src/UniGetUI.Core.LanguageEngine/Assets/Data/TranslatedPercentages.json'
-      - 'src/UniGetUI.Core.LanguageEngine/Assets/Data/Translators.json'
+      - 'src/Languages/**'
+      - 'src/Languages/Data/LanguagesReference.json'
+      - 'src/Languages/Data/TranslatedPercentages.json'
+      - 'src/Languages/Data/Translators.json'
       - 'src/UniGetUI.Core.Data/Assets/Data/Contributors.list'
       - '.github/workflows/translation-validation.yml'
 
@@ -18,10 +18,10 @@ on:
     paths:
       - 'scripts/translation/**'
       - '.agents/skills/translation-*/scripts/**'
-      - 'src/UniGetUI.Core.LanguageEngine/Assets/Languages/**'
-      - 'src/UniGetUI.Core.LanguageEngine/Assets/Data/LanguagesReference.json'
-      - 'src/UniGetUI.Core.LanguageEngine/Assets/Data/TranslatedPercentages.json'
-      - 'src/UniGetUI.Core.LanguageEngine/Assets/Data/Translators.json'
+      - 'src/Languages/**'
+      - 'src/Languages/Data/LanguagesReference.json'
+      - 'src/Languages/Data/TranslatedPercentages.json'
+      - 'src/Languages/Data/Translators.json'
       - 'src/UniGetUI.Core.Data/Assets/Data/Contributors.list'
       - '.github/workflows/translation-validation.yml'
 

AGENTS.md

@@ -76,7 +76,7 @@ File-based settings via `Settings.Get(Settings.K.*)` / `Settings.Set(Settings.K.
 Use `Logger.Info()`, `Logger.Warn()`, `Logger.Error()`, `Logger.Debug()`, `Logger.ImportantInfo()` from `UniGetUI.Core.Logging`. Accepts both `string` and `Exception` parameters.
 
 ### Localization
-Use `CoreTools.Translate("text")` for all user-facing strings. Parameterized: `CoreTools.Translate("{0} packages found", count)`. In XAML, use the `TranslatedTextBlock` control. Translation assets live under `src/UniGetUI.Core.LanguageEngine/Assets/`; do not assume Tolgee-based automation exists in this repository.
+Use `CoreTools.Translate("text")` for all user-facing strings. Parameterized: `CoreTools.Translate("{0} packages found", count)`. In XAML, use the `TranslatedTextBlock` control. Translation assets live under `src/Languages/`; do not assume Tolgee-based automation exists in this repository.
 
 ### Naming
 - Types, methods, properties: **PascalCase**