fix serialization tests not passing

Author: marticliment

src/UniGetUI.Core.Settings.Tests/SettingsTest.cs

@@ -173,7 +173,7 @@ public void TestListSettings(string SettingName, string[] ls1Array, int[] ls2Arr
             Assert.Equal("this is now a test case", Settings.GetListItem<string>(SettingName, 3));
             Assert.Null(Settings.GetListItem<string>(SettingName, 4));
 
-            Assert.Equal(Settings.GetListItem<string>(SettingName, 0), JsonSerializer.Deserialize<List<string>>(File.ReadAllText(Path.Join(CoreData.UniGetUIUserConfigurationDirectory, $"{SettingName}.json")), CoreData.SerializingOptions)[0]);
+            Assert.Equal(Settings.GetListItem<string>(SettingName, 0), JsonSerializer.Deserialize<List<string>>(File.ReadAllText(Path.Join(CoreData.UniGetUIUserConfigurationDirectory, $"{SettingName}.json")), Settings.SerializationOptions)[0]);
             Settings.ClearList(SettingName);
             Assert.Empty(Settings.GetList<object>(SettingName) ?? ["this shouldn't be null; something's wrong"]);
 
@@ -226,7 +226,7 @@ public void TestDictionarySettings(string SettingName, string[] keyArray, int[]
             Settings.SetDictionaryItem(randStr, "key", 12);
             Assert.Equal(12, Settings.GetDictionaryItem<string, int>(randStr, "key"));
             Settings.SetDictionary(SettingName, test);
-            Assert.Equal(JsonSerializer.Serialize(test, CoreData.SerializingOptions), File.ReadAllText(Path.Join(CoreData.UniGetUIUserConfigurationDirectory, $"{SettingName}.json")));
+            Assert.Equal(JsonSerializer.Serialize(test, Settings.SerializationOptions), File.ReadAllText(Path.Join(CoreData.UniGetUIUserConfigurationDirectory, $"{SettingName}.json")));
             Assert.Equal(test[keyArray[0]]?.sub.count, Settings.GetDictionary<string, SerializableTest?>(SettingName)?[keyArray[0]]?.sub.count);
             Assert.Equal(test[keyArray[1]]?.sub.count, Settings.GetDictionaryItem<string, SerializableTest?>(SettingName, keyArray[1])?.sub.count);
             Settings.SetDictionaryItem(SettingName, keyArray[0], test[keyArray[1]]);
@@ -257,7 +257,7 @@ public void TestDictionarySettings(string SettingName, string[] keyArray, int[]
             Assert.True(Settings.DictionaryContainsValue<string, SerializableTest?>(SettingName, test[keyArray[2]]));
 
             Assert.Equal(
-                JsonSerializer.Serialize(Settings.GetDictionary<string, SerializableTest>(SettingName), CoreData.SerializingOptions),
+                JsonSerializer.Serialize(Settings.GetDictionary<string, SerializableTest>(SettingName), Settings.SerializationOptions),
                 File.ReadAllText(Path.Join(CoreData.UniGetUIUserConfigurationDirectory, $"{SettingName}.json"))
             );
 

src/UniGetUI.Core.Settings/SettingsEngine_Extras.cs

@@ -86,7 +86,7 @@ public static void SetProxyCredentials(string username, string password)
         }
     }
 
-    private static JsonSerializerOptions SerializationOptions = new()
+    public static JsonSerializerOptions SerializationOptions = new()
     {
         TypeInfoResolver = new DefaultJsonTypeInfoResolver(),
         AllowTrailingCommas = true,

src/UniGetUI.Core.Tools.Tests/MetaTests.cs

@@ -17,8 +17,10 @@ public void TestJsonSerializationOptions()
             var lines = File.ReadAllLines(file);
             var jsonSerCount = lines.Count(x => x.Contains("JsonSerializer.Serialize"));
             var jsonDeserCount = lines.Count(x => x.Contains("JsonSerializer.Deserialize"));
-            var serialOptionsCount = lines.Count(x => x.Contains("CoreData.DefaultOptions"));
-            Assert.True((jsonSerCount + jsonDeserCount) <= serialOptionsCount,
+            var serialOptionsCount1 = lines.Count(x => x.Contains("SerializationHelpers.DefaultOptions"));
+            var serialOptionsCount2 = lines.Count(x => x.Contains("SerializationHelpers.ImportBundleOptions"));
+            var serialOptionsCount3 = lines.Count(x => x.Contains("SerializationOptions"));
+            Assert.True((jsonSerCount + jsonDeserCount) <= serialOptionsCount1 + serialOptionsCount2 + serialOptionsCount3,
                 $"Failing on {file}. The specified file does not serialize and/or deserialize JSON with" +
                 $" the proper CoreData.DefaultOptions set");
         }

src/UniGetUI.Core.Tools/SerializationHelpers.cs

@@ -28,7 +28,7 @@ private static string xml_to_json(string XML)
         var doc = new XmlDocument();
         doc.LoadXml(XML);
         if (doc.DocumentElement is null) return "{'message': 'XmlDocument.DocumentElement was null'}";
-        return JsonSerializer.Serialize(_convertXmlNode(doc.DocumentElement), DefaultOptions);
+        return JsonSerializer.Serialize(_convertXmlNode(doc.DocumentElement), SerializationHelpers.DefaultOptions);
     }
 
     private static object? _convertXmlNode(XmlNode node)