Fix a potential bug in TaskRecycler

marticliment · marticliment · commit 8a7af3adfc89 · 2025-04-25T23:04:22.000+02:00
diff --git a/src/UniGetUI.Core.Classes/TaskRecycler.cs b/src/UniGetUI.Core.Classes/TaskRecycler.cs
@@ -121,7 +121,7 @@ private static async Task _runTaskAndWait_VOID(Task task, int hash, int cacheTim
         await task;
 
         // Schedule the task for removal after the cache time expires
-        _removeFromCache(hash, cacheTimeSecsSecs);
+        _removeFromCache_VOID(hash, cacheTimeSecsSecs);
     }
 
     /// <summary>
@@ -166,6 +166,14 @@ private static async void _removeFromCache(int hash, int cacheTimeSecsSecs)
 
         _tasks.Remove(hash, out _);
     }
+
+    private static async void _removeFromCache_VOID(int hash, int cacheTimeSecsSecs)
+    {
+        if (cacheTimeSecsSecs > 0)
+            await Task.Delay(cacheTimeSecsSecs * 1000);
+
+        _tasks_VOID.Remove(hash, out _);
+    }
 }
 
 public static class TaskRecyclerTelemetry

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ private static async Task _runTaskAndWait_VOID(Task task, int hash, int cacheTim`
`121`	`121`	`await task;`
`122`	`122`
`123`	`123`	`// Schedule the task for removal after the cache time expires`
`124`		`- _removeFromCache(hash, cacheTimeSecsSecs);`
	`124`	`+ _removeFromCache_VOID(hash, cacheTimeSecsSecs);`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`/// <summary>`
`@@ -166,6 +166,14 @@ private static async void _removeFromCache(int hash, int cacheTimeSecsSecs)`
`166`	`166`
`167`	`167`	`_tasks.Remove(hash, out _);`
`168`	`168`	`}`
	`169`	`+`
	`170`	`+ private static async void _removeFromCache_VOID(int hash, int cacheTimeSecsSecs)`
	`171`	`+ {`
	`172`	`+ if (cacheTimeSecsSecs > 0)`
	`173`	`+ await Task.Delay(cacheTimeSecsSecs * 1000);`
	`174`	`+`
	`175`	`+ _tasks_VOID.Remove(hash, out _);`
	`176`	`+ }`
`169`	`177`	`}`
`170`	`178`
`171`	`179`	`public static class TaskRecyclerTelemetry`