Move security check to SerializableInstallationOptions.getParameters

Author: marticliment

src/UniGetUI.PackageEngine.PackageManagerClasses/Manager/Helpers/BasePkgOperationHelper.cs

@@ -29,19 +29,7 @@ public IReadOnlyList<string> GetParameters(IPackage package,
         SerializableInstallationOptions options,
         OperationType operation)
     {
-        var parameters = _getOperationParameters(package, options, operation).ToArray();
-
-        for (int i = 0; i < parameters.Length; i++)
-        {
-            parameters[i] = parameters[i]
-                .Replace("&", "")
-                .Replace("|", "")
-                .Replace(";", "")
-                .Replace("<", "")
-                .Replace(">", "")
-                .Replace("\n", "");
-        }
-
+        var parameters = _getOperationParameters(package, options, operation);
         Logger.Info($"Loaded operation parameters for package id={package.Id} on manager {Manager.Name} and operation {operation}: " +
                     string.Join(' ', parameters));
         return parameters.Where(x => x.Any()).ToArray();

src/UniGetUI.PackageEngine.Serializable/SerializableInstallationOptions.cs

@@ -48,8 +48,9 @@ public override void LoadFromJson(JsonNode data)
             this.InstallationScope = data[nameof(InstallationScope)]?.GetVal<string>() ?? "";
 
             this.CustomParameters = new List<string>();
-            foreach(var element in data[nameof(CustomParameters)]?.AsArray2() ?? [])
-                if (element is not null) this.CustomParameters.Add(element.GetVal<string>());
+            foreach (var element in data[nameof(CustomParameters)]?.AsArray2() ?? [])
+                if (element is not null)
+                    this.CustomParameters.Add(element.GetVal<string>());
 
             this.PreRelease = data[nameof(PreRelease)]?.GetVal<bool>() ?? false;
             this.CustomInstallLocation = data[nameof(CustomInstallLocation)]?.GetVal<string>() ?? "";
@@ -61,6 +62,22 @@ public override void LoadFromJson(JsonNode data)
             // This entry shall be checked the last one, to ensure all other properties are set
             this.OverridesNextLevelOpts =
                 data[nameof(OverridesNextLevelOpts)]?.GetValue<bool>() ?? DiffersFromDefault();
+
+            SanitizeOptions();
+        }
+
+        private void SanitizeOptions()
+        {
+            for (int i = 0; i < this.CustomParameters.Count; i++)
+            {
+                this.CustomParameters[i] = this.CustomParameters[i]
+                    .Replace("&", "")
+                    .Replace("|", "")
+                    .Replace(";", "")
+                    .Replace("<", "")
+                    .Replace(">", "")
+                    .Replace("\n", "");
+            }
         }
 
         public bool DiffersFromDefault()