Guess file type via http request, migrate GetFileSizeAsyncAsLong to HttpClient

Author: marticliment

src/Directory.Build.props

@@ -5,7 +5,7 @@
         <TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
         <!-- IF BUILD FAILS DUE TO MISSING Microsoft.Management.Deployment NAMESPACE,
             TOGGLE THE LAST NUMBER OF THE LINE BELOW 1 UNIT UP OR DOWN, AND REBUILD-->
-        <WindowsSdkPackageVersion>10.0.26100.57</WindowsSdkPackageVersion>
+        <WindowsSdkPackageVersion>10.0.26100.56</WindowsSdkPackageVersion>
 
         <SdkVersion>8.0.407</SdkVersion>
         <Authors>Martí Climent and the contributors</Authors>

src/UniGetUI.Core.Tools/Tools.cs

@@ -272,33 +272,53 @@ public static double GetFileSize(Uri? url)
 
         public static async Task<long> GetFileSizeAsyncAsLong(Uri? url)
         {
-            if (url is null)
+            if (url is null) return 0;
+
+            try
+            {
+                using HttpClient client = new(CoreTools.GenericHttpClientParameters);
+                HttpResponseMessage response = await client.SendAsync(new HttpRequestMessage(HttpMethod.Head, url));
+                return response.Content.Headers.ContentLength ?? 0;
+            }
+            catch (Exception e)
             {
-                return 0;
+                Logger.Warn($"Could not load file size for url={url}");
+                Logger.Warn(e);
             }
 
+            return 0;
+        }
+
+        public static string GetFileName(Uri url)
+        {
             try
             {
-#pragma warning disable SYSLIB0014 // Type or member is obsolete
-                WebRequest req = WebRequest.Create(url);
-#pragma warning restore SYSLIB0014 // Type or member is obsolete
-                req.Method = "HEAD";
-                WebResponse resp = await req.GetResponseAsync();
-                if (long.TryParse(resp.Headers.Get("Content-Length"), out long ContentLength))
+                var handler = CoreTools.GenericHttpClientParameters;
+                handler.AllowAutoRedirect = false;
+                using HttpClient client = new(handler);
+                HttpResponseMessage response = client.Send(new HttpRequestMessage(HttpMethod.Head, url));
+
+                if (response.StatusCode is HttpStatusCode.Moved or HttpStatusCode.Redirect
+                    or HttpStatusCode.RedirectMethod or HttpStatusCode.TemporaryRedirect
+                    or HttpStatusCode.PermanentRedirect)
                 {
-                    return ContentLength;
+                    return GetFileName(response.Headers.Location ??
+                                       throw new HttpRequestException("A redirect code was returned but no new location was given"));
                 }
 
+                return response.Content.Headers.ContentDisposition?.FileName ?? Path.GetFileName(url.LocalPath);
             }
             catch (Exception e)
             {
-                Logger.Warn($"Could not load file size for url={url}");
+                Logger.Warn($"Failed to retrieve file name for URL: {url}");
                 Logger.Warn(e);
+                return string.Empty;
             }
-
-            return 0;
         }
 
+        public static Task<string> GetFileNameAsync(Uri url)
+            => Task.Run(() => GetFileName(url));
+
 
         public struct Version: IComparable
         {

src/UniGetUI/AppOperationHelper.cs

@@ -80,13 +80,24 @@ public static void Remove(AbstractOperation op)
                 WinRT.Interop.InitializeWithWindow.Initialize(savePicker, hWnd);
                 savePicker.SuggestedStartLocation = PickerLocationId.Downloads;
 
-                string extension = CoreTools.MakeValidFileName(details.InstallerUrl.ToString().Split('.')[^1]);
-                if (package.Manager is Cargo) extension = "zip";
-                savePicker.SuggestedFileName = package.Id + " installer." + extension;
+                string name = await CoreTools.GetFileNameAsync(details.InstallerUrl);
+                string extension;
+                if (!name.Where(x => x == '.').Any())
+                {
+                    extension = package.Manager is Cargo? "zip": "exe";
+                    name = name + "." + extension;
+                }
+                else
+                {
+                    extension = CoreTools.MakeValidFileName(name.Split('.')[^1]);
+                }
+
+                savePicker.SuggestedFileName = name;
 
                 if (package.Manager is BaseNuGet)
                 {
                     extension = "nupkg";
+                    savePicker.FileTypeChoices.Add("NuGet package", [".nupkg"]);
                     savePicker.FileTypeChoices.Add("Compressed file", [".zip"]);
                 }