Merge pull request #3822 from marticliment/dependencies

marticliment · web-flow · commit aa9d47e00336 · 2025-07-08T00:13:21.000+02:00
diff --git a/src/UniGetUI.PAckageEngine.Interfaces/IPackageDetails.cs b/src/UniGetUI.PAckageEngine.Interfaces/IPackageDetails.cs
@@ -94,5 +94,14 @@ public interface IPackageDetails
         /// </summary>
         /// <returns>An asynchronous task that can be awaited</returns>
         public Task Load();
+
+        public List<Dependency> Dependencies { get; }
+
+        public struct Dependency
+        {
+            public string Name;
+            public string Version;
+            public bool Mandatory;
+        }
     }
 }
diff --git a/src/UniGetUI.PackageEngine.Enums/ManagerCapabilities.cs b/src/UniGetUI.PackageEngine.Enums/ManagerCapabilities.cs
@@ -25,6 +25,7 @@ public struct ManagerCapabilities
         public bool CanRemoveDataOnUninstall = false;
         public bool CanDownloadInstaller = false;
         public bool CanUninstallPreviousVersionsAfterUpdate = false;
+        public bool CanListDependencies = false;
         public bool SupportsCustomVersions = false;
         public bool SupportsCustomArchitectures = false;
         public string[] SupportedCustomArchitectures = [];
diff --git a/src/UniGetUI.PackageEngine.Managers.Chocolatey/Chocolatey.cs b/src/UniGetUI.PackageEngine.Managers.Chocolatey/Chocolatey.cs
@@ -32,6 +32,7 @@ public Chocolatey()
                 CanSkipIntegrityChecks = true,
                 CanRunInteractively = true,
                 SupportsCustomVersions = true,
+                CanListDependencies = true,
                 SupportsCustomArchitectures = true,
                 SupportedCustomArchitectures = [Architecture.x86],
                 SupportsPreRelease = true,
diff --git a/src/UniGetUI.PackageEngine.Managers.Dotnet/DotNet.cs b/src/UniGetUI.PackageEngine.Managers.Dotnet/DotNet.cs
@@ -30,6 +30,7 @@ public DotNet()
                 SupportsCustomArchitectures = true,
                 SupportedCustomArchitectures = [Architecture.x86, Architecture.x64, Architecture.arm64, Architecture.arm32],
                 SupportsPreRelease = true,
+                CanListDependencies = true,
                 SupportsCustomLocations = true,
                 SupportsCustomPackageIcons = true,
                 SupportsCustomVersions = true,
diff --git a/src/UniGetUI.PackageEngine.Managers.Generic.NuGet/BaseNuGet.cs b/src/UniGetUI.PackageEngine.Managers.Generic.NuGet/BaseNuGet.cs
@@ -18,20 +18,19 @@ public abstract class BaseNuGet : PackageManager
 
         public sealed override void Initialize()
         {
-            if (DetailsHelper is not BaseNuGetDetailsHelper)
+            static void ThrowIC(string name)
             {
-                throw new InvalidOperationException("NuGet-based package managers must not reassign the PackageDetailsProvider property");
+                throw new InvalidOperationException($"NuGet-based package managers must have Capabilities.{name} set to true");
             }
 
-            if (!Capabilities.SupportsCustomVersions)
+            if (DetailsHelper is not BaseNuGetDetailsHelper)
             {
-                throw new InvalidOperationException("NuGet-based package managers must support custom versions");
+                throw new InvalidOperationException("NuGet-based package managers must not reassign the PackageDetailsProvider property");
             }
 
-            if (!Capabilities.SupportsCustomPackageIcons)
-            {
-                throw new InvalidOperationException("NuGet-based package managers must support custom versions");
-            }
+            if (!Capabilities.SupportsCustomVersions) ThrowIC(nameof(Capabilities.SupportsCustomVersions));
+            if (!Capabilities.SupportsCustomPackageIcons) ThrowIC(nameof(Capabilities.SupportsCustomPackageIcons));
+            if (!Capabilities.CanListDependencies) ThrowIC(nameof(Capabilities.CanListDependencies));
 
             base.Initialize();
         }
diff --git a/src/UniGetUI.PackageEngine.Managers.Generic.NuGet/BaseNuGetDetailsHelper.cs b/src/UniGetUI.PackageEngine.Managers.Generic.NuGet/BaseNuGetDetailsHelper.cs
@@ -107,6 +107,25 @@ protected override void GetDetails_UnSafe(IPackageDetails details)
                     break;
                 }
 
+                details.Dependencies.Clear();
+                foreach (Match match in Regex.Matches(PackageManifestContents,
+                             @"<d\:Dependencies>([^<]+)</d\:Dependencies>"))
+                {
+                    foreach (var dep in match.Groups[1].ToString().Split('|'))
+                    {
+                        if(string.IsNullOrEmpty(dep))
+                            continue;
+                        else if (dep.StartsWith("::"))
+                            details.Dependencies.Add(new() { Name = dep.TrimStart(':'), Version = "", Mandatory = true });
+                        else
+                            details.Dependencies.Add(new()
+                        {
+                            Name = dep.Split(':')[0], Version = dep.Split(':')[1].TrimEnd(':'), Mandatory = true
+                        });
+                    }
+                }
+
+
                 logger.Close(0);
                 return;
             }
diff --git a/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgDetailsHelper.cs b/src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgDetailsHelper.cs
@@ -61,6 +61,47 @@ protected override void GetDetails_UnSafe(IPackageDetails details)
 
                 details.InstallerHash = contents?["dist"]?["integrity"]?.ToString();
 
+                details.Dependencies.Clear();
+                HashSet<string> addedDeps = new();
+                foreach (var rawDep in (contents?["dependencies"]?.AsObject() ?? []))
+                {
+                    if(addedDeps.Contains(rawDep.Key)) continue;
+                    addedDeps.Add(rawDep.Key);
+
+                    details.Dependencies.Add(new()
+                    {
+                        Name = rawDep.Key,
+                        Version = rawDep.Value?.GetValue<string>() ?? "",
+                        Mandatory = true,
+                    });
+                }
+
+                foreach (var rawDep in (contents?["devDependencies"]?.AsObject() ?? []))
+                {
+                    if(addedDeps.Contains(rawDep.Key)) continue;
+                    addedDeps.Add(rawDep.Key);
+
+                    details.Dependencies.Add(new()
+                    {
+                        Name = rawDep.Key,
+                        Version = rawDep.Value?.GetValue<string>() ?? "",
+                        Mandatory = false,
+                    });
+                }
+
+                foreach (var rawDep in (contents?["peerDependencies"]?.AsObject() ?? []))
+                {
+                    if(addedDeps.Contains(rawDep.Key)) continue;
+                    addedDeps.Add(rawDep.Key);
+
+                    details.Dependencies.Add(new()
+                    {
+                        Name = rawDep.Key,
+                        Version = rawDep.Value?.GetValue<string>() ?? "",
+                        Mandatory = false,
+                    });
+                }
+
                 logger.AddToStdErr(p.StandardError.ReadToEnd());
                 p.WaitForExit();
                 logger.Close(p.ExitCode);
diff --git a/src/UniGetUI.PackageEngine.Managers.Npm/Npm.cs b/src/UniGetUI.PackageEngine.Managers.Npm/Npm.cs
@@ -23,6 +23,7 @@ public Npm()
                 SupportsCustomVersions = true,
                 CanDownloadInstaller = true,
                 SupportsCustomScopes = true,
+                CanListDependencies = true,
                 SupportsPreRelease = true,
                 SupportsProxy = ProxySupport.No,
                 SupportsProxyAuth = false
diff --git a/src/UniGetUI.PackageEngine.Managers.Pip/Helpers/PipPkgDetailsHelper.cs b/src/UniGetUI.PackageEngine.Managers.Pip/Helpers/PipPkgDetailsHelper.cs
@@ -55,6 +55,19 @@ protected override void GetDetails_UnSafe(IPackageDetails details)
                     }
                     details.Tags = Tags.ToArray();
                 }
+
+                details.Dependencies.Clear();
+                foreach (var rawDep in (info?["requires_dist"]?.AsArray() ?? []))
+                {
+                    string line = rawDep?.GetValue<string>().Split(';')[0] ?? "";
+                    string name = line.Split(['>', '<', '=', '!'])[0];
+                    details.Dependencies.Add(new()
+                    {
+                        Name = name,
+                        Version = line[name.Length..],
+                        Mandatory = true,
+                    });
+                }
             }
 
             JsonObject? url = contents?["url"] as JsonObject;
diff --git a/src/UniGetUI.PackageEngine.Managers.Pip/Pip.cs b/src/UniGetUI.PackageEngine.Managers.Pip/Pip.cs
@@ -50,6 +50,7 @@ public Pip()
                 SupportsCustomScopes = true,
                 CanDownloadInstaller = true,
                 SupportsPreRelease = true,
+                CanListDependencies = true,
                 SupportsProxy = ProxySupport.Yes,
                 SupportsProxyAuth = true
             };
diff --git a/src/UniGetUI.PackageEngine.Managers.PowerShell/PowerShell.cs b/src/UniGetUI.PackageEngine.Managers.PowerShell/PowerShell.cs
@@ -25,6 +25,7 @@ public PowerShell()
                 SupportsCustomVersions = true,
                 CanDownloadInstaller = true,
                 SupportsCustomScopes = true,
+                CanListDependencies = true,
                 SupportsCustomSources = true,
                 SupportsPreRelease = true,
                 SupportsCustomPackageIcons = true,
diff --git a/src/UniGetUI.PackageEngine.Managers.PowerShell7/PowerShell7.cs b/src/UniGetUI.PackageEngine.Managers.PowerShell7/PowerShell7.cs
@@ -26,6 +26,7 @@ public PowerShell7()
                 SupportsCustomSources = true,
                 SupportsPreRelease = true,
                 CanDownloadInstaller = true,
+                CanListDependencies = true,
                 SupportsCustomPackageIcons = true,
                 CanUninstallPreviousVersionsAfterUpdate = true,
                 Sources = new SourceCapabilities
diff --git a/src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgDetailsHelper.cs b/src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgDetailsHelper.cs
@@ -157,9 +157,64 @@ protected override void GetDetails_UnSafe(IPackageDetails details)
                     out var releaseNotesUrl))
                 details.ReleaseNotesUrl = releaseNotesUrl;
 
+            details.Dependencies.Clear();
+            _getDepends(details, contents);
+            _getSuggests(details, contents);
+
             logger.Close(0);
         }
 
+        private static void _getSuggests(IPackageDetails details, JsonObject? contents)
+        {
+            foreach (var rawDep in (contents?["suggest"]?.AsObject() ?? []))
+            {
+                List<string> innerDeps = [];
+
+                if(rawDep.Value is JsonValue value) innerDeps.Add(value.GetValue<string>());
+                else
+                {
+                    foreach (var iDep in rawDep.Value?.AsArray() ?? [])
+                    {
+                        string? val = iDep?.GetValue<string>();
+                        if(val is not null) innerDeps.Add(val);
+                    }
+                }
+
+                foreach(var val in innerDeps)
+                    details.Dependencies.Add(new()
+                    {
+                        Name = val,
+                        Version = "",
+                        Mandatory = false,
+                    });
+            }
+        }
+
+        private static void _getDepends(IPackageDetails details, JsonObject? contents)
+        {
+            var node = contents?["depends"];
+            List<string> innerDeps = [];
+
+
+            if(node is JsonValue value) innerDeps.Add(value.GetValue<string>());
+            else
+            {
+                foreach (var iDep in node?.AsArray() ?? [])
+                {
+                    string? val = iDep?.GetValue<string>();
+                    if(val is not null) innerDeps.Add(val);
+                }
+            }
+
+            foreach(var val in innerDeps)
+                details.Dependencies.Add(new()
+                {
+                    Name = val,
+                    Version = "",
+                    Mandatory = true,
+                });
+        }
+
         protected override CacheableIcon? GetIcon_UnSafe(IPackage package)
         {
             throw new NotImplementedException();
diff --git a/src/UniGetUI.PackageEngine.Managers.Scoop/Scoop.cs b/src/UniGetUI.PackageEngine.Managers.Scoop/Scoop.cs
@@ -51,6 +51,7 @@ public Scoop()
                 CanRunAsAdmin = true,
                 CanSkipIntegrityChecks = true,
                 CanDownloadInstaller = true,
+                CanListDependencies = true,
                 CanRemoveDataOnUninstall = true,
                 SupportsCustomArchitectures = true,
                 SupportedCustomArchitectures = [Architecture.x86, Architecture.x64, Architecture.arm64],
diff --git a/src/UniGetUI.PackageEngine.Managers.Vcpkg/Helpers/VcpkgPkgDetailsHelper.cs b/src/UniGetUI.PackageEngine.Managers.Vcpkg/Helpers/VcpkgPkgDetailsHelper.cs
@@ -54,6 +54,16 @@ protected override void GetDetails_UnSafe(IPackageDetails details)
 
             details.Tags = Tags.ToArray();
 
+            details.Dependencies.Clear();
+            foreach (var iDep in contents?["dependencies"]?.AsArray() ?? [])
+            {
+                string? val = iDep?.GetValue<string>();
+                if (val is not null)
+                {
+                    details.Dependencies.Add(new() { Name = val, Version = "", Mandatory = true, });
+                }
+            }
+
             logger.Close(0);
         }
 
diff --git a/src/UniGetUI.PackageEngine.Managers.Vcpkg/Vcpkg.cs b/src/UniGetUI.PackageEngine.Managers.Vcpkg/Vcpkg.cs
@@ -42,6 +42,7 @@ public Vcpkg()
             {
                 CanRunAsAdmin = true,
                 SupportsCustomSources = true,
+                CanListDependencies = true,
                 SupportsProxy = ProxySupport.No,
                 SupportsProxyAuth = false,
             };
diff --git a/src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/BundledWinGetHelper.cs b/src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/BundledWinGetHelper.cs
@@ -461,6 +461,8 @@ public void GetPackageDetails_UnSafe(IPackageDetails details)
         bool IsLoadingDescription = false;
         bool IsLoadingReleaseNotes = false;
         bool IsLoadingTags = false;
+        bool IsCapturingDependencies = false;
+        details.Dependencies.Clear();
         foreach (string __line in output)
         {
             try
@@ -484,6 +486,16 @@ public void GetPackageDetails_UnSafe(IPackageDetails details)
                 {
                     details.Tags = details.Tags.Append(line.Trim()).ToArray();
                 }
+                else if (line.StartsWith(" ") && IsCapturingDependencies)
+                {
+                    line = line.Trim();
+                    details.Dependencies.Add(new()
+                    {
+                        Name = line.Split(' ')[0],
+                        Version = line.Contains('[') ? line.Split('[')[1].TrimEnd(']'): "",
+                        Mandatory = true
+                    });
+                }
 
                 // Stop loading multiline fields
                 else if (IsLoadingDescription)
@@ -498,6 +510,10 @@ public void GetPackageDetails_UnSafe(IPackageDetails details)
                 {
                     IsLoadingTags = false;
                 }
+                else if (IsCapturingDependencies)
+                {
+                    IsCapturingDependencies = false;
+                }
 
                 // Check for single-line fields
                 if (line.Contains("Publisher:"))
@@ -556,6 +572,10 @@ public void GetPackageDetails_UnSafe(IPackageDetails details)
                     details.Tags = [];
                     IsLoadingTags = true;
                 }
+                else if (line.Contains("- Package Dependencies"))
+                {
+                    IsCapturingDependencies = true;
+                }
             }
             catch (Exception e)
             {
diff --git a/src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/NativeWinGetHelper.cs b/src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/NativeWinGetHelper.cs
@@ -396,6 +396,8 @@ public void GetPackageDetails_UnSafe(IPackageDetails details)
 
         logger.Error(process.StandardError.ReadToEnd());
 
+        bool capturingDependencies = false;
+        details.Dependencies.Clear();
         // Parse the output
         foreach (string __line in output)
         {
@@ -419,6 +421,20 @@ public void GetPackageDetails_UnSafe(IPackageDetails details)
                 {
                     details.InstallerType = line.Split(":")[1].Trim();
                 }
+                else if (line.Contains("- Package Dependencies"))
+                {
+                    capturingDependencies = true;
+                }
+                else if (__line.Contains("        ") && capturingDependencies)
+                {
+                    details.Dependencies.Add(new()
+                    {
+                        Name = line.Split(' ')[0],
+                        Version = line.Contains('[') ? line.Split('[')[1].TrimEnd(']'): "",
+                        Mandatory = true
+                    });
+                }
+                else if (!__line.Contains("        ")) capturingDependencies = false;
             }
             catch (Exception e)
             {
diff --git a/src/UniGetUI.PackageEngine.Managers.WinGet/WinGet.cs b/src/UniGetUI.PackageEngine.Managers.WinGet/WinGet.cs
@@ -43,6 +43,7 @@ public WinGet()
                 CanRunInteractively = true,
                 SupportsCustomVersions = true,
                 CanDownloadInstaller = true,
+                CanListDependencies = true,
                 SupportsCustomArchitectures = true,
                 SupportedCustomArchitectures = [Architecture.x86, Architecture.x64, Architecture.arm64],
                 SupportsCustomScopes = true,
diff --git a/src/UniGetUI.PackageEngine.PackageManagerClasses/Packages/Classes/PackageDetails.cs b/src/UniGetUI.PackageEngine.PackageManagerClasses/Packages/Classes/PackageDetails.cs
@@ -94,6 +94,8 @@ public class PackageDetails : IPackageDetails
         /// </summary>
         public string[] Tags { get; set; } = [];
 
+        public List<IPackageDetails.Dependency> Dependencies { get; set; } = [];
+
         public PackageDetails(IPackage package)
         {
             Package = package;
diff --git a/src/UniGetUI/Pages/DialogPages/PackageDetailsPage.xaml b/src/UniGetUI/Pages/DialogPages/PackageDetailsPage.xaml
diff --git a/src/UniGetUI/Pages/DialogPages/PackageDetailsPage.xaml.cs b/src/UniGetUI/Pages/DialogPages/PackageDetailsPage.xaml.cs

Original file line number	Diff line number	Diff line change
`@@ -18,20 +18,19 @@ public abstract class BaseNuGet : PackageManager`
`18`	`18`
`19`	`19`	`public sealed override void Initialize()`
`20`	`20`	`{`
`21`		`- if (DetailsHelper is not BaseNuGetDetailsHelper)`
	`21`	`+ static void ThrowIC(string name)`
`22`	`22`	`{`
`23`		`- throw new InvalidOperationException("NuGet-based package managers must not reassign the PackageDetailsProvider property");`
	`23`	`+ throw new InvalidOperationException($"NuGet-based package managers must have Capabilities.{name} set to true");`
`24`	`24`	`}`
`25`	`25`
`26`		`- if (!Capabilities.SupportsCustomVersions)`
	`26`	`+ if (DetailsHelper is not BaseNuGetDetailsHelper)`
`27`	`27`	`{`
`28`		`- throw new InvalidOperationException("NuGet-based package managers must support custom versions");`
	`28`	`+ throw new InvalidOperationException("NuGet-based package managers must not reassign the PackageDetailsProvider property");`
`29`	`29`	`}`
`30`	`30`
`31`		`- if (!Capabilities.SupportsCustomPackageIcons)`
`32`		`- {`
`33`		`- throw new InvalidOperationException("NuGet-based package managers must support custom versions");`
`34`		`- }`
	`31`	`+ if (!Capabilities.SupportsCustomVersions) ThrowIC(nameof(Capabilities.SupportsCustomVersions));`
	`32`	`+ if (!Capabilities.SupportsCustomPackageIcons) ThrowIC(nameof(Capabilities.SupportsCustomPackageIcons));`
	`33`	`+ if (!Capabilities.CanListDependencies) ThrowIC(nameof(Capabilities.CanListDependencies));`
`35`	`34`
`36`	`35`	`base.Initialize();`
`37`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,19 @@ protected override void GetDetails_UnSafe(IPackageDetails details)`
`55`	`55`	`}`
`56`	`56`	`details.Tags = Tags.ToArray();`
`57`	`57`	`}`
	`58`	`+`
	`59`	`+ details.Dependencies.Clear();`
	`60`	`+ foreach (var rawDep in (info?["requires_dist"]?.AsArray() ?? []))`
	`61`	`+ {`
	`62`	`+ string line = rawDep?.GetValue<string>().Split(';')[0] ?? "";`
	`63`	`+ string name = line.Split(['>', '<', '=', '!'])[0];`
	`64`	`+ details.Dependencies.Add(new()`
	`65`	`+ {`
	`66`	`+ Name = name,`
	`67`	`+ Version = line[name.Length..],`
	`68`	`+ Mandatory = true,`
	`69`	`+ });`
	`70`	`+ }`
`58`	`71`	`}`
`59`	`72`
`60`	`73`	`JsonObject? url = contents?["url"] as JsonObject;`