Skip to content

Commit b505369

Browse files
committed
Remove unused setting
1 parent bef5b4a commit b505369

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

src/UniGetUI.Core.Settings/SettingsEngine_Names.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ public enum K
7777
KillProcessesThatRefuseToDie,
7878
ManagerPaths,
7979
GitHubUserLogin,
80-
GitHubGistId,
8180

8281
Test1,
8382
Test2,
@@ -166,7 +165,6 @@ public static string ResolveKey(K key)
166165
K.KillProcessesThatRefuseToDie => "KillProcessesThatRefuseToDie",
167166
K.ManagerPaths => "ManagerPaths",
168167
K.GitHubUserLogin => "GitHubUserLogin",
169-
K.GitHubGistId => "GitHubGistId",
170168

171169
K.Test1 => "TestSetting1",
172170
K.Test2 => "TestSetting2",

src/UniGetUI/Services/GitHubAuthService.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ public class GitHubAuthService
1818
private const string RedirectUri = "http://127.0.0.1:58642/";
1919

2020
private readonly GitHubClient _client;
21-
private const Settings.K GitHubUserLoginSettingKey = Settings.K.GitHubUserLogin;
2221

2322
public GitHubAuthService()
2423
{
@@ -119,7 +118,7 @@ private async Task<bool> CompleteSignInAsync(string code)
119118
var user = await userClient.User.Current();
120119
if (user != null)
121120
{
122-
Settings.SetValue(GitHubUserLoginSettingKey, user.Login);
121+
Settings.SetValue(Settings.K.GitHubUserLogin, user.Login);
123122
Logger.Info($"Logged in as GitHub user: {user.Login}");
124123
}
125124
else
@@ -145,10 +144,10 @@ public async Task SignOutAsync()
145144
Logger.Info("GitHub sign-out complete.");
146145
}
147146

148-
private async Task ClearAuthenticatedUserDataAsync()
147+
private static async Task ClearAuthenticatedUserDataAsync()
149148
{
150149
await SecureTokenManager.DeleteTokenAsync();
151-
Settings.SetValue(GitHubUserLoginSettingKey, ""); // Clear stored username
150+
Settings.SetValue(Settings.K.GitHubUserLogin, ""); // Clear stored username
152151
}
153152

154153
public async Task<string?> GetAccessTokenAsync()
@@ -158,7 +157,7 @@ private async Task ClearAuthenticatedUserDataAsync()
158157

159158
public async Task<string?> GetAuthenticatedUserLoginAsync()
160159
{
161-
string? storedLogin = Settings.GetValue(GitHubUserLoginSettingKey);
160+
string? storedLogin = Settings.GetValue(Settings.K.GitHubUserLogin);
162161
await Task.CompletedTask;
163162
return string.IsNullOrEmpty(storedLogin) ? null : storedLogin;
164163
}

0 commit comments

Comments
 (0)