Fix not being able to ignore updates (fix #3608)

Author: marticliment

src/UniGetUI.PackageEngine.PackageLoader/AbstractPackageLoader.cs

@@ -279,7 +279,7 @@ public void Remove(IPackage? package)
                 return;
             }
 
-            PackageReference.Remove(HashPackage(package), out IPackage? _);
+            PackageReference.Remove(HashPackage(package), out IPackage? pkg);
             InvokePackagesChangedEvent(true, [], [package]);
         }
 

src/UniGetUI/Controls/ObservablePackageCollection.cs

@@ -77,19 +77,6 @@ public void SetSorter(Sorter field)
             }
         }
 
-        /// <summary>
-        /// Clears the collection, deleting the wrapper objects in the process
-        /// </summary>
-        public new void Clear()
-        {
-            foreach (PackageWrapper wrapper in this)
-            {
-                wrapper.Dispose();
-            }
-            base.Clear();
-            GC.Collect();
-        }
-
         /// <summary>
         /// Returns a list containing the packages in this collection
         /// </summary>

src/UniGetUI/Controls/PackageWrapper.cs

@@ -119,7 +119,8 @@ public void Package_PropertyChanged(object? sender, PropertyChangedEventArgs e)
                 {
                     PropertyChanged?.Invoke(this, e);
                 }
-            } catch (COMException)
+            }
+            catch (COMException)
             {
                 // ignore
             }

src/UniGetUI/Pages/SoftwarePages/AbstractPackagesPage.xaml.cs

@@ -425,15 +425,23 @@ private void Loader_PackagesChanged(object? sender, PackagesChangedEvent package
                 }
 
                 // Remove removed packages
+                var toRemove = new List<PackageWrapper>();
                 foreach (var package in packagesChangedEvent.RemovedPackages)
                     foreach (var match in WrappedPackages.Where(w => w.Package.Equals(package)))
                     {
-                        WrappedPackages.Remove(match);
+                        toRemove.Add(match);
                     }
+
+                foreach (var wrapper in toRemove)
+                {
+                    wrapper.Dispose();
+                    WrappedPackages.Remove(wrapper);
+                }
             }
             else
             {
                 // Reset internal package cache, and update from loader
+                foreach(var wrapper in WrappedPackages) wrapper.Dispose();
                 WrappedPackages.Clear();
                 ClearSourcesList();
                 foreach (var package in Loader.Packages)

src/UniGetUI/Pages/SoftwarePages/InstalledPackagesPage.cs

@@ -438,7 +438,9 @@ private async void MenuIgnorePackage_Invoked(object sender, RoutedEventArgs args
             if (package is null) return;
 
             if (await package.HasUpdatesIgnoredAsync())
+            {
                 await package.RemoveFromIgnoredUpdatesAsync();
+            }
             else
             {
                 await package.AddToIgnoredUpdatesAsync();