Merge pull request #3827 from theguy000/feat/recheck-version-before-update

Author: marticliment

src/UniGetUI.PackageEngine.Operations/PackageOperations.cs

@@ -242,7 +242,8 @@ public UpdatePackageOperation(
             bool IgnoreParallelInstalls = false,
             AbstractOperation? req = null)
             : base(package, options, OperationType.Update, IgnoreParallelInstalls, req)
-        { }
+        {
+        }
 
         protected override Task HandleFailure()
         {

src/UniGetUI.PackageEngine.PackageManagerClasses/Packages/Classes/PackageCacher.cs

@@ -102,7 +102,7 @@ public static bool NewerVersionIsInstalled(Package other)
         {
             foreach (Package found in __installed_pkgs.Values)
             {
-                if (found.IsEquivalentTo(other) && found.NormalizedVersion == other.NormalizedNewVersion)
+                if (found.IsEquivalentTo(other) && found.NormalizedVersion >= other.NormalizedNewVersion)
                 {
                     return true;
                 }

src/UniGetUI/AppOperationHelper.cs

@@ -193,6 +193,17 @@ public static void Install(IReadOnlyList<IPackage> packages, TEL_InstallReferral
         public static async Task<AbstractOperation?> Update(IPackage? package, bool? elevated = null, bool? interactive = null, bool? no_integrity = null, bool ignoreParallel = false, AbstractOperation? req = null)
         {
             if (package is null) return null;
+            if (package.NewerVersionIsInstalled())
+            {
+                Logger.Warn($"A newer version of {package.Id} has been detected, the update will not be performed!");
+                PEInterface.UpgradablePackagesLoader.Remove(package);
+                foreach (var eq in PEInterface.InstalledPackagesLoader.GetEquivalentPackages(package))
+                {   // Remove upgradable tag from all installed packages
+                    eq.Tag = PackageTag.Default;
+                }
+
+                return null;
+            }
 
             var options = await InstallOptionsFactory.LoadApplicableAsync(package, elevated, interactive, no_integrity);
             var operation = new UpdatePackageOperation(package, options, ignoreParallel, req);