Skip to content

Fix Minor Update Check #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martí Climent (marticliment) merged 2 commits into from
Apr 17, 2025
Merged

Fix Minor Update Check #3573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
674a00a
Fix minor update check
mrixner Apr 16, 2025
b902335
Merge branch 'main' into fix-minor-update-check
marticliment Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/UniGetUI.PackageEngine.PackageLoader/UpgradablePackagesLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ protected override async Task<bool> IsPackageValid(IPackage package)
IgnoredPackages[package.Id] = package;
return false;
}
if ((await InstallationOptions.FromPackageAsync(package)).SkipMinorUpdates && package.IsUpdateMinor()) return false;
if ((await InstallationOptions.FromPackageAsync(package)).SkipMinorUpdates && package.IsUpdateMinor())
{
Logger.Info($"Ignoring package {package.Id} because it is a minor update ({package.VersionString} -> {package.NewVersionString}) and SkipMinorUpdates is set to true.");
return false;
}
if (package.NewerVersionIsInstalled()) return false;
return true;
}
Expand Down
13 changes: 2 additions & 11 deletions src/UniGetUI.PackageEngine.PackageManagerClasses/Packages/Package.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,18 +296,9 @@ public virtual bool NewerVersionIsInstalled()
public virtual bool IsUpdateMinor()
{
if (!IsUpgradable) return false;
string[] VersionSplit = VersionString.Split(".");
string[] NewVersionSplit = NewVersionString.Split(".");

// When in doubt, return false
if (VersionSplit.Length < 3 || NewVersionSplit.Length < 3) return false;

if (
VersionSplit[0] != NewVersionSplit[0] ||
VersionSplit[1] != NewVersionSplit[1]
) return false; // Major update

return VersionSplit[2].CompareTo(NewVersionSplit[2]) < 0;
return NormalizedVersion.Major == NormalizedNewVersion.Major && NormalizedVersion.Minor == NormalizedNewVersion.Minor &&
(NormalizedVersion.Patch != NormalizedNewVersion.Patch || NormalizedVersion.Remainder != NormalizedNewVersion.Remainder);
}

public virtual SerializablePackage_v1 AsSerializable()
Expand Down
Loading