Improve local icon detection code comments#3767
Merged
Martí Climent (marticliment) merged 1 commit intoJun 20, 2025
Merged
Conversation
To improve clarity for future readers of this complicated string truncation, the comments have been relocated to more obviously show what segments they are detailing and why each line does what it does for Microsoft Store icons.
Martí Climent (marticliment)
approved these changes
Jun 20, 2025
Martí Climent (marticliment)
merged commit c58e06f
into
Devolutions:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
To improve clarity for future readers of this complicated string truncation, the comments have been relocated to more obviously show what segments they are detailing and why each line does what it does for Microsoft Store icons.