Add ARM getfilesiginforedist.dll and update installer to install ARM64 extras#4564
Open
Hernan Martinez (hmartinez82) wants to merge 3 commits intoDevolutions:mainfrom
Open
Add ARM getfilesiginforedist.dll and update installer to install ARM64 extras#4564Hernan Martinez (hmartinez82) wants to merge 3 commits intoDevolutions:mainfrom
getfilesiginforedist.dll and update installer to install ARM64 extras#4564Hernan Martinez (hmartinez82) wants to merge 3 commits intoDevolutions:mainfrom
Conversation
Hernan Martinez (hmartinez82)
changed the title
getfilesiginforedist.dll native binary to output folder in arm64 buildsgetfilesiginforedist.dll and update installer to install ARM64 extras
| '/passive /norestart', | ||
| 'Visual C++ 2015-2022 Redistributable (x64)' + Dependency_ArchTitle, | ||
| Dependency_String('https://aka.ms/vs/17/release/vc_redist.x64.exe', 'https://aka.ms/vs/17/release/vc_redist.x64.exe'), | ||
| Dependency_String('https://aka.ms/vc14/vc_redist.x64.exe', 'https://aka.ms/vc14/vc_redist.x64.exe'), |
There was a problem hiding this comment.
See note for x64 Installer at https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#latest-supported-redistributable-version and why it can be used on ARM64 too.
Contributor
|
Thanks, getfilesiginforedist.dll is that last thing that eluded me for arm64. I'll see about getting the gsudo patches done in the right place tomorrow, then I'll release the gsudo nuget, and then we can update it in UniGetUI. Do you understand what this DLL is truly used for? |
Author
|
I take it's native code that goes with the Microsoft.Security.Extensions managed code? probably for checking if a file passes authenticode validation. I've never used that NuGet package myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
Adds the missing ARM64
getfilesiginforedist.dllnative binary, copied from https://www.nuget.org/packages/Microsoft.Security.Extensions, version 1.4.0, runtimewin-arm64Feel free to override the file with your own copy, although the file I added in this PR is signed by Microsoft.
Relates to #2407