fix(dgw): set TCP_NODELAY on all TCP sockets

(WIP)

Author: CBenoit

crates/jmux-proxy/src/lib.rs

@@ -928,6 +928,10 @@ impl StreamResolverTask {
         match scheme {
             "tcp" => match TcpStream::connect((host, port)).await {
                 Ok(stream) => {
+                    if let Err(error) = stream.set_nodelay(true) {
+                        warn!(%error, "Failed to set TCP_NODELAY on the socket");
+                    }
+
                     internal_msg_tx
                         .send(InternalMessage::StreamResolved { channel, stream })
                         .await

devolutions-gateway/src/listener.rs

@@ -115,6 +115,8 @@ async fn run_tcp_listener(listener: TcpListener, state: DgwState) -> anyhow::Res
     loop {
         match listener.accept().await.context("failed to accept connection") {
             Ok((stream, peer_addr)) => {
+                configure_tcp_socket(&stream);
+
                 let state = state.clone();
 
                 ChildTask::spawn(async move {
@@ -131,10 +133,6 @@ async fn run_tcp_listener(listener: TcpListener, state: DgwState) -> anyhow::Res
 
 #[instrument("tcp", skip_all, fields(client = %peer_addr))]
 async fn handle_tcp_peer(stream: TcpStream, state: DgwState, peer_addr: SocketAddr) -> anyhow::Result<()> {
-    if let Err(e) = stream.set_nodelay(true) {
-        error!("set_nodelay on TcpStream failed: {}", e);
-    }
-
     let mut peeked = [0; 4];
     let n_read = stream
         .peek(&mut peeked)
@@ -168,6 +166,8 @@ async fn run_http_listener(listener: TcpListener, state: DgwState) -> anyhow::Re
     loop {
         match listener.accept().await {
             Ok((stream, peer_addr)) => {
+                configure_tcp_socket(&stream);
+
                 let state = state.clone();
 
                 let fut = tokio::time::timeout(HTTP_CONNECTION_MAX_DURATION, async move {
@@ -195,6 +195,8 @@ async fn run_https_listener(listener: TcpListener, state: DgwState) -> anyhow::R
     loop {
         match listener.accept().await {
             Ok((stream, peer_addr)) => {
+                configure_tcp_socket(&stream);
+
                 let tls_acceptor = tls_conf.acceptor.clone();
                 let state = state.clone();
 
@@ -285,3 +287,9 @@ impl ToInternalUrl for Url {
         self
     }
 }
+
+fn configure_tcp_socket(socket: &TcpStream) {
+    if let Err(error) = socket.set_nodelay(true) {
+        warn!(%error, "Failed to set TCP_NODELAY on the socket");
+    }
+}

jetsocat/src/pipe.rs

@@ -156,6 +156,10 @@ pub async fn open_pipe(mode: PipeMode, proxy_cfg: Option<ProxyConfig>) -> Result
                 .context("failed to bind TCP listener")?;
             let (socket, peer_addr) = listener.accept().await.context("TCP listener couldn't accept")?;
 
+            if let Err(error) = socket.set_nodelay(true) {
+                warn!(%error, "Failed to set TCP_NODELAY on the socket");
+            }
+
             info!(%peer_addr, "Accepted peer");
 
             Ok(Pipe {

jetsocat/src/utils.rs

@@ -73,6 +73,11 @@ macro_rules! impl_tcp_connect {
                 let dest_addr =
                     resolve_dest_addr($req_addr.to_dest_addr().with_context(|| "invalid target address")?).await?;
                 let $stream = TcpStream::connect(dest_addr).await?;
+
+                if let Err(error) = $stream.set_nodelay(true) {
+                    warn!(%error, "Failed to set TCP_NODELAY on the socket");
+                }
+
                 $operation.await
             }
         };