Skip to content

Commit 1b06033

Browse files
committed
refactor(webapp): update calls to onSessionEvent
Update calls to onSessionEvent from @devolutions/iron-remote-desktop, as the interface changed after RxJS was removed from latter's dependencies.
1 parent e003be2 commit 1b06033

5 files changed

Lines changed: 47 additions & 80 deletions

File tree

webapp/package-lock.json

Lines changed: 7 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webapp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@angular/platform-browser-dynamic": "18.2.1",
2929
"@angular/router": "18.2.1",
3030
"@devolutions/icons": "4.0.8",
31-
"@devolutions/iron-remote-desktop": "^0.2.0",
31+
"@devolutions/iron-remote-desktop": "file:~/Projects/ironrdp/web-client/iron-remote-desktop/dist",
3232
"@devolutions/iron-remote-desktop-rdp": "^0.1.1",
3333
"@devolutions/iron-remote-desktop-vnc": "^0.2.1",
3434
"@devolutions/web-ssh-gui": "0.3.1",

webapp/src/client/app/modules/web-client/ard/web-client-ard.component.ts

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -358,20 +358,19 @@ export class WebClientArdComponent extends WebClientBaseComponent implements OnI
358358
}
359359

360360
private initSessionEventHandler(): void {
361-
this.remoteClient.onSessionEvent({
362-
next: (event: SessionEvent): void => {
363-
switch (event.type) {
364-
case SessionEventType.STARTED:
365-
this.handleSessionStarted(event);
366-
break;
367-
case SessionEventType.TERMINATED:
368-
case SessionEventType.ERROR:
369-
this.handleSessionEndedOrError(event);
370-
break;
371-
}
372-
},
373-
error: (err) => this.handleSubscriptionError(err),
374-
});
361+
const handler = (event: SessionEvent): void => {
362+
switch (event.type) {
363+
case SessionEventType.STARTED:
364+
this.handleSessionStarted(event);
365+
break;
366+
case SessionEventType.TERMINATED:
367+
case SessionEventType.ERROR:
368+
this.handleSessionEndedOrError(event);
369+
break;
370+
}
371+
};
372+
373+
this.remoteClient.onSessionEvent(handler);
375374
}
376375

377376
private handleSessionStarted(event: SessionEvent): void {
@@ -409,10 +408,6 @@ export class WebClientArdComponent extends WebClientBaseComponent implements OnI
409408
void this.webSessionService.updateWebSessionIcon(this.webSessionId, icon);
410409
}
411410

412-
private handleSubscriptionError(error): void {
413-
console.error('Error in session event subscription', error);
414-
}
415-
416411
private handleIronRDPError(error: IronError | string): void {
417412
this.notifyUserAboutError(error);
418413
this.disableComponentStatus();

webapp/src/client/app/modules/web-client/rdp/web-client-rdp.component.ts

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -420,20 +420,19 @@ export class WebClientRdpComponent extends WebClientBaseComponent implements OnI
420420
}
421421

422422
private initSessionEventHandler(): void {
423-
this.remoteClient.onSessionEvent({
424-
next: (event: SessionEvent): void => {
425-
switch (event.type) {
426-
case SessionEventType.STARTED:
427-
this.handleSessionStarted(event);
428-
break;
429-
case SessionEventType.TERMINATED:
430-
case SessionEventType.ERROR:
431-
this.handleSessionEndedOrError(event);
432-
break;
433-
}
434-
},
435-
error: (err) => this.handleSubscriptionError(err),
436-
});
423+
const handler = (event: SessionEvent): void => {
424+
switch (event.type) {
425+
case SessionEventType.STARTED:
426+
this.handleSessionStarted(event);
427+
break;
428+
case SessionEventType.TERMINATED:
429+
case SessionEventType.ERROR:
430+
this.handleSessionEndedOrError(event);
431+
break;
432+
}
433+
};
434+
435+
this.remoteClient.onSessionEvent(handler);
437436
}
438437

439438
private handleSessionStarted(event: SessionEvent): void {
@@ -471,10 +470,6 @@ export class WebClientRdpComponent extends WebClientBaseComponent implements OnI
471470
void this.webSessionService.updateWebSessionIcon(this.webSessionId, icon);
472471
}
473472

474-
private handleSubscriptionError(error): void {
475-
console.error('Error in session event subscription', error);
476-
}
477-
478473
private handleIronRDPError(error: IronError | string): void {
479474
this.notifyUserAboutError(error);
480475
this.disableComponentStatus();

webapp/src/client/app/modules/web-client/vnc/web-client-vnc.component.ts

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -433,20 +433,19 @@ export class WebClientVncComponent extends WebClientBaseComponent implements OnI
433433
}
434434

435435
private initSessionEventHandler(): void {
436-
this.remoteClient.onSessionEvent({
437-
next: (event: SessionEvent): void => {
438-
switch (event.type) {
439-
case SessionEventType.STARTED:
440-
this.handleSessionStarted(event);
441-
break;
442-
case SessionEventType.TERMINATED:
443-
case SessionEventType.ERROR:
444-
this.handleSessionEndedOrError(event);
445-
break;
446-
}
447-
},
448-
error: (err) => this.handleSubscriptionError(err),
449-
});
436+
const handler = (event: SessionEvent): void => {
437+
switch (event.type) {
438+
case SessionEventType.STARTED:
439+
this.handleSessionStarted(event);
440+
break;
441+
case SessionEventType.TERMINATED:
442+
case SessionEventType.ERROR:
443+
this.handleSessionEndedOrError(event);
444+
break;
445+
}
446+
};
447+
448+
this.remoteClient.onSessionEvent(handler);
450449
}
451450

452451
private handleSessionStarted(event: SessionEvent): void {
@@ -484,10 +483,6 @@ export class WebClientVncComponent extends WebClientBaseComponent implements OnI
484483
void this.webSessionService.updateWebSessionIcon(this.webSessionId, icon);
485484
}
486485

487-
private handleSubscriptionError(error): void {
488-
console.error('Error in session event subscription', error);
489-
}
490-
491486
private handleIronRDPError(error: IronError | string): void {
492487
this.notifyUserAboutError(error);
493488
this.disableComponentStatus();

0 commit comments

Comments
 (0)