Skip to content

refactor(dgw): redo ipconfig#1300

Merged
irvingouj@Devolutions (irvingoujAtDevolution) merged 6 commits intomasterfrom
redo-ipconfig
Apr 10, 2025
Merged

refactor(dgw): redo ipconfig#1300
irvingouj@Devolutions (irvingoujAtDevolution) merged 6 commits intomasterfrom
redo-ipconfig

Conversation

@irvingoujAtDevolution
Copy link
Copy Markdown
Contributor

@irvingoujAtDevolution irvingouj@Devolutions (irvingoujAtDevolution) commented Apr 8, 2025

Move on to a simpler interface. Do not extract route information anymore.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2025

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

devolutions-gateway/src/api/net.rs:232

  • [nitpick] The field name 'addr' might be misleading since it holds multiple addresses; consider renaming it to 'addresses' for improved clarity.
pub addr: Vec<Addr>,

crates/network-scanner/src/interfaces/mod.rs:1

  • [nitpick] The import 'NetworkInterfaceConfig' does not appear to be used; removing it could clean up the code.
use network_interface::NetworkInterfaceConfig;

Comment thread devolutions-gateway/src/api/net.rs Outdated
pub struct NetworkInterface {
pub name: String,
#[cfg_attr(feature = "openapi", schema(value_type = Vec<Addr>))]
pub addr: Vec<Addr>,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming: plural

Suggested change
pub addr: Vec<Addr>,
pub addrs: Vec<Addr>,

Comment thread devolutions-gateway/src/api/net.rs Outdated
pub prefixlen: u32,
pub struct NetworkInterface {
pub name: String,
#[cfg_attr(feature = "openapi", schema(value_type = Vec<Addr>))]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Do you really need to re-specify the schema value type?

@CBenoit Benoît Cortier (CBenoit) changed the title refractor(dgw): redo ipconfig refactor(dgw): redo ipconfig Apr 10, 2025
Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approving so you can merge yourself once you are done with suggested modifications.

@irvingoujAtDevolution irvingouj@Devolutions (irvingoujAtDevolution) merged commit 9d689ce into master Apr 10, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants