refactor(dgw): redo ipconfig#1300
refactor(dgw): redo ipconfig#1300irvingouj@Devolutions (irvingoujAtDevolution) merged 6 commits intomasterfrom
Conversation
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
devolutions-gateway/src/api/net.rs:232
- [nitpick] The field name 'addr' might be misleading since it holds multiple addresses; consider renaming it to 'addresses' for improved clarity.
pub addr: Vec<Addr>,
crates/network-scanner/src/interfaces/mod.rs:1
- [nitpick] The import 'NetworkInterfaceConfig' does not appear to be used; removing it could clean up the code.
use network_interface::NetworkInterfaceConfig;
| pub struct NetworkInterface { | ||
| pub name: String, | ||
| #[cfg_attr(feature = "openapi", schema(value_type = Vec<Addr>))] | ||
| pub addr: Vec<Addr>, |
There was a problem hiding this comment.
naming: plural
| pub addr: Vec<Addr>, | |
| pub addrs: Vec<Addr>, |
| pub prefixlen: u32, | ||
| pub struct NetworkInterface { | ||
| pub name: String, | ||
| #[cfg_attr(feature = "openapi", schema(value_type = Vec<Addr>))] |
There was a problem hiding this comment.
question: Do you really need to re-specify the schema value type?
Benoît Cortier (CBenoit)
left a comment
There was a problem hiding this comment.
LGTM! Approving so you can merge yourself once you are done with suggested modifications.
9d689ce
into
master
Move on to a simpler interface. Do not extract route information anymore.