Skip to content

refactor(pedm): modify serve arguments#1301

Merged
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom
pedm-sql-init
Apr 9, 2025
Merged

refactor(pedm): modify serve arguments#1301
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom
pedm-sql-init

Conversation

@allan2
Copy link
Copy Markdown
Contributor

@allan2 Allan Zhang (allan2) commented Apr 8, 2025

  • serve now takes a Config struct rather than a path
    • pipe name is now part of Config rather than a direct argument
  • Config struct is now exported as devolutions_pedm::Config
  • serve is now exported as devolutions_pedm::serve

@allan2
refactor(pedm): modify serve arguments
d69e9c0 
- `serve` arguments are changed
  - it now takes the `Config` struct instead of a path
  - pipe name is now part of `Config` rather than a direct argument
- `Config` struct is now exported as `devolutions_pedm::Config`
  - it can be used by server implementations directly
- `serve` is now exported as `devolutions_pedm::serve`
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2025

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@allan2
Fix Linux build
c75a0df
@allan2
Fix api module publicity
f53a93c 
This commit makes it public again. It is used by the generate-openapi
tool in the `devolutions_pedm::api::openapi` call.
Allan Zhang (allan2) added a commit that referenced this pull request Apr 8, 2025
@allan2
Merge branch pedm-sql-init into pedm-sql-init3
70b2349 
This adds changes added to PR #1301.
@allan2 Allan Zhang (allan2) mentioned this pull request Apr 8, 2025
Merged
CBenoit
Benoît Cortier (CBenoit) reviewed Apr 9, 2025
View reviewed changes
Comment thread crates/devolutions-pedm/src/config.rs
impl Config {
/// Creates a new config with the default values for a new setup.
fn standard() -> Self {
pub fn standard() -> Self {
Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Sounds like it should be Default::default()

CBenoit
Benoît Cortier (CBenoit) approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It’s better that way. Thank you!

@CBenoit Benoît Cortier (CBenoit) merged commit 46435e5 into master Apr 9, 2025
39 checks passed
@CBenoit Benoît Cortier (CBenoit) deleted the pedm-sql-init branch April 9, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CBenoit Benoît Cortier (CBenoit) CBenoit approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allan2 @CBenoit