Skip to content

feat(webapp): add wheel_speed_factor setting to a VNC and ARD connection forms#1362

Merged
Benoît Cortier (CBenoit) merged 2 commits into
masterfrom
webapp-wheel-speed-factor
May 30, 2025
Merged

feat(webapp): add wheel_speed_factor setting to a VNC and ARD connection forms#1362
Benoît Cortier (CBenoit) merged 2 commits into
masterfrom
webapp-wheel-speed-factor

Conversation

@RRRadicalEdward
Copy link
Copy Markdown
Collaborator

@RRRadicalEdward Alex Yusiuk (RRRadicalEdward) commented May 27, 2025

It looks this way
image

@github-actions
Copy link
Copy Markdown

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@RRRadicalEdward
Copy link
Copy Markdown
Collaborator Author

Alex Yusiuk (RRRadicalEdward) commented May 27, 2025

CI failed with some weird errors:
image
image

I hope a rerun will help.
EDIT: I didn't help

Comment thread webapp/src/client/app/modules/web-client/ard/web-client-ard.component.ts Outdated
Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I reported the error to DevOps. It may be related to the secrets.

@CBenoit Benoît Cortier (CBenoit) enabled auto-merge (squash) May 27, 2025 13:25
@CBenoit
Copy link
Copy Markdown
Member

Alex Yusiuk (@RRRadicalEdward) should be fixed if you rebase on master!

@CBenoit
Copy link
Copy Markdown
Member

Alex Yusiuk (@RRRadicalEdward) It also occurred to me that this could be a "runtime" option in top bar so the user can adjust even after starting the session.

@RRRadicalEdward
Copy link
Copy Markdown
Collaborator Author

Alex Yusiuk (@RRRadicalEdward) It also occurred to me that this could be a "runtime" option in top bar so the user can adjust even after starting the session.

We can do it. It will require some refactoring in IronVNC since right now the setting can't be changed after the session is started - https://github.com/Devolutions/IronVNC/blob/master/crates/ironvnc-web/src/session.rs#L807

@RRRadicalEdward
Copy link
Copy Markdown
Collaborator Author

Alex Yusiuk (@RRRadicalEdward) should be fixed if you rebase on master!

Seems like, there are still some issues
image

@CBenoit
Copy link
Copy Markdown
Member

Benoît Cortier (CBenoit) commented May 29, 2025

Alex Yusiuk (@RRRadicalEdward) now this should be fixed for real, I rebased the PR 🙂

EDIT: Apparently it’s still red. I reported to our DevOps team.

@CBenoit
Copy link
Copy Markdown
Member

Benoît Cortier (CBenoit) commented May 29, 2025

Alex Yusiuk (@RRRadicalEdward) It also occurred to me that this could be a "runtime" option in top bar so the user can adjust even after starting the session.

We can do it. It will require some refactoring in IronVNC since right now the setting can't be changed after the session is started - https://github.com/Devolutions/IronVNC/blob/master/crates/ironvnc-web/src/session.rs#L807

I see, yes. We could add a new event UiEvent::SetWheelSpeedFactor that is triggered by passing a set_wheel_speed_factor extension to extension_call. That would be a good opportunity to test the design of extension_call.

@CBenoit Benoît Cortier (CBenoit) merged commit e6be3d0 into master May 30, 2025
39 checks passed
@CBenoit Benoît Cortier (CBenoit) deleted the webapp-wheel-speed-factor branch May 30, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants