feat(webapp): add wheel_speed_factor setting to a VNC and ARD connection forms#1362
Conversation
Let maintainers know that an action is required on their side
|
Benoît Cortier (CBenoit)
left a comment
There was a problem hiding this comment.
LGTM!
I reported the error to DevOps. It may be related to the secrets.
|
Alex Yusiuk (@RRRadicalEdward) should be fixed if you rebase on master! |
|
Alex Yusiuk (@RRRadicalEdward) It also occurred to me that this could be a "runtime" option in top bar so the user can adjust even after starting the session. |
We can do it. It will require some refactoring in IronVNC since right now the setting can't be changed after the session is started - https://github.com/Devolutions/IronVNC/blob/master/crates/ironvnc-web/src/session.rs#L807 |
1886b31 to
d6061dc
Compare
|
d6061dc to
6399927
Compare
|
Alex Yusiuk (@RRRadicalEdward) now this should be fixed for real, I rebased the PR 🙂 EDIT: Apparently it’s still red. I reported to our DevOps team. |
I see, yes. We could add a new event |
6399927 to
1fb05b7
Compare



It looks this way
