fix(dgw)!: fail-fast on improper certificate for TLS#1391
Merged
Conversation
When the certificate is missing the auth extended key usage, or does not have any subject alternative name: - fail on startup for certificates from filesystem, and - fail on certificate resolution for system certificate store. Issue: DGW-286
Benoît Cortier (CBenoit)
changed the title
Vladyslav Nikonov (pacmancoder)
approved these changes
Jun 23, 2025
Vladyslav Nikonov (pacmancoder)
left a comment
Vladyslav Nikonov (pacmancoder)
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certificates missing the auth extended key usage, or missing a subject alternative name are now rejected:
Issue: DGW-286