Summary
`CheckForUpdate()` in `internal/update/update.go` returns an empty string on both "no newer version available" and "network/parse error during check". Callers cannot distinguish the two states, so update check failures are silently swallowed — users never know when the check is broken.
Details
- Current signature: `func CheckForUpdate() string`
- On any error (HTTP failure, JSON parse failure, version parse failure), the function returns `""` — identical to "you are on the latest version"
- No logging occurs on failure, so there is no way to diagnose broken update checks
Checklist
References
- `internal/update/update.go:150-178`
Raised from senior code review (2026-05-12).
Summary
`CheckForUpdate()` in `internal/update/update.go` returns an empty string on both "no newer version available" and "network/parse error during check". Callers cannot distinguish the two states, so update check failures are silently swallowed — users never know when the check is broken.
Details
Checklist
References
Raised from senior code review (2026-05-12).